Missing new 1.16.0 enchantment

[IdanHo]

No new enchantments were added since 1.13.2 (and as such no version since 1.13.2 had an enchantments.json file), and as such were missing the new Soul Speed enchant added in 1.16.0

[nickelpro]

No version since 1.13.2 has an enchantments field included in dataPaths.json at all. It's more correct to say no version since 1.13.2 has ported the enchantment data forward at all, largely because it's all manual work and enchantment data is little used. This was attempted to be addressed by #287 and the associated PR on the wiki extractor, but the wiki doesn't provide all needed data for the MCD schema.

The immediate issue of hand porting enchantments.json forward for 1.14+ is easy and I assume Rom will accept a PR if you do that. The more complete answer is to write a new topping for Burger that extracts this data.

[nickelpro]

I've identified the class for extracting the data and intend to take a wack at building the burger extractor sometime this week when I have a minute. As long as we're doing this we can grab some other stuff MCD doesn't track like rarity and equipment slot.

@rom1504 Is it ok to add schema fields as long as we maintain old ones?

[IdanHo]

I'd be happy to open a pull request for the enchantments myself, but i can wait as well for the extractor if youd like.

[nickelpro]

If it's not urgent, give me two days and I should have something working. It's a little harder than the two-line extractor you'd want it to be because MC changed the way these pseudo-enumerated types worked around 1.13, so getting support for all the versions Burger works on can be a little tricky.

[rom1504]

Sure it's fine to add new fields

…

On Tue, Aug 11, 2020, 02:53 Vito Gamberini ***@***.***> wrote: If it's not urgent, give me two days and I should have something working. It's a little harder than the two-line extractor you'd want it to be because MC changed the way these pseudo-enumerated types worked around 1.13, so getting support for all the versions Burger works on can be a little tricky. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#325 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAR437VZ4QWDCMMOFDYYKM3SACJARANCNFSM4P2NQLXQ> .

[nickelpro]

So I've run into a little bit of a snag

The sequential Window IDs for enchantment are not the same as the deprecated NBT IDs for enchantments. For example in 1.13.2 the NBT ID for "punch" is 49, but the Window ID is 23. The NBT IDs are completely deprecated and any assignement in later versions will be arbitrary, and in earlier versions we need to add a "window_id" field. The Soul Speed enchantment is a good example, it has no NBT ID field listed anywhere in the jar since it came about after they were removed.

What's the best way to indicate a deprecated field in MCD? Leave it blank? Set to zero? Remove it entirely?

[rom1504]

any assignement in later versions will be arbitrary

What do you mean by arbitrary, do they still use them ?

[nickelpro]

No, the NBT IDs are not used at all in later versions. They only exist in "Fix" classes that map old enchantment data to the new format, for updating existing world files. Soul Speed did not exist in old versions and therefore doesn't even have an ID listed there.

[rom1504]

Ok then add both fields and fill them only for the versions where it makes sense

[Karang]

done