-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Walking improvements: Directions API, Elevations API #413
Comments
I like the idea, I placed a google API there to simulate people walk. Use google direction Walk mode would generate human walk logic. |
add I already have some basic working code |
there will be some integration work needed, please take a look then rewrite if needed I wrote it with the logic in mind that when we initiate a walk we know from were to where we want to go, thus I would initialise an object current_walk = PolylineWalker([polylines_points_list], speed) object with the fetched polylines points from Google Directions API
Pause/Unpause (Not sure if needed)
|
got rid of the .walk() concept.. the are no methods anymore that update the .points content, the points remain the same during the life of the object with the initial points initialized from the Google Direction API fetched points. if the polyline walk was finished the .get_pos() continues to return the position of the last point. any proposals/preferences what should the object return? |
more improvements #697 |
more improvements #721 |
Maybe change sometime a little bit the movements speed. So the bot will look more natural |
Good suggestion! Posible solutions:
|
I did a PR #835 to push some fixes to master branch |
Will need to rewrite some code due to the big refactor to Stepper class #737 |
routing the generated point to 5 digits precision ensure we are around ~50 cm around the point proposed by the Google Direction API. I that good enough as a jitter? |
Proposing a new Interface for the StepWalker configuration https://github.com/th3w4y/PokemonGo-Bot/pull/24 |
* hotfix for pokemon spawn disappearing * replace marker if disappear_time is different (different item) * better fix * removed disappear time thing... time will always be different * pokemon were flashing... this is prob the problem
is there anything in your TODO list for this?
Was thinking to add a new walk logic to use the map generated by the Directions API for generating a polyline that would need to be walked with the speed that is set.
Additionally for the generated point we could fetch the alt from the Elevations API
this can improve the self.set_position(lat, lng, alt)
maybe this will make the bot walk more natural.
What are your opinions on this?
The text was updated successfully, but these errors were encountered: