Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the ItemHealDataEditor which could introduce ALL in the status list #353

Conversation

Zodiarche
Copy link
Collaborator

@Zodiarche Zodiarche commented Jul 6, 2024

Description

  • For the heal item, we can configure the heal settings.
  • In the case of using statuses, if the care applies to all statuses, an incorrect value may be entered in a particular circumstance: opening and closing the editor will add ALL to the data if nothing is edited and "All statuses" was already selected before opening the editor.

=> statusList should be contains : "POISONED", "PARALYZED", "BURN", "ASLEEP", "FROZEN", "TOXIC", "CONFUSION" now.

  • I also changed the -3 to -2 to include the confusion.

Tests to perform

  1. Go on the Lum Berry item
  2. Open the heal editor
  3. Close the heal editor
  4. Save
  5. Open the json lum_berry.json and see the issue
  6. Try to open the project after modification

Copy link
Collaborator

@AerunDev AerunDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pour moi c'est nickel, mais on a un souci : avec la modification de la liste pour intégrer CONFUSED, la Baie Prine (Lum Berry) soigne désormais la confusion. Hors, ce n'est pas censé être possible. La confusion, comme la peur, sont des status volatiles, d'où le fait qu'on les avait retiré.

@Palbolsky
Copy link
Collaborator

Palbolsky commented Jul 7, 2024

Pour moi c'est nickel, mais on a un souci : avec la modification de la liste pour intégrer CONFUSED, la Baie Prine (Lum Berry) soigne désormais la confusion. Hors, ce n'est pas censé être possible. La confusion, comme la peur, sont des status volatiles, d'où le fait qu'on les avait retiré.

Pas d'après Bulbapedia ^^'

image

@AerunDev
Copy link
Collaborator

AerunDev commented Jul 7, 2024

C'est moi qui ai mal lu, mon mauvais !

@AerunDev AerunDev merged commit 191f9bf into develop Jul 7, 2024
2 checks passed
@AerunDev AerunDev deleted the fix-the-itemhealdataeditor-which-could-introduce-all-in-the-status-list branch July 7, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the ItemHealDataEditor which could introduce ALL in the status list
3 participants