Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): checkbox input updates #70

Merged
merged 4 commits into from
May 7, 2024
Merged

Conversation

joshuagraber
Copy link
Collaborator

Resolves #62

To test

  1. Run npm run dev
  2. Ensure that the test form works properly with the checkbox and it's styled appropriately

Copy link

@vikramrojo vikramrojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a look and have some feedback:

  • I think the cursor should change to interactive click
  • Possibly the click target should be larger

@joshuagraber
Copy link
Collaborator Author

Possibly the click target should be larger

@vikramrojo Can you say more about this? The checkbox and its label are clickable. What part are you wanting to be larger?

@vikramrojo
Copy link

@joshuagraber maybe it was just the missing cursor, but I couldn't make out what the target area was. It looks good now.

@vikramrojo vikramrojo self-requested a review May 6, 2024 22:37
Copy link

@vikramrojo vikramrojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design wise it looks good.

@joshuagraber joshuagraber merged commit 621064b into beta May 7, 2024
5 checks passed
@joshuagraber joshuagraber deleted the feat/checkbox-input branch May 7, 2024 14:54
Copy link

🎉 This PR is included in version 2.7.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@joshuagraber joshuagraber mentioned this pull request May 28, 2024
@joshuagraber joshuagraber changed the title feat: checkbox input feat: checkbox input updates Jun 3, 2024
@joshuagraber joshuagraber changed the title feat: checkbox input updates feat(components): checkbox input updates Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants