-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: search-v2 #78
feat: search-v2 #78
Conversation
…esign-system into beta
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 4.5.1 to 4.5.3. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v4.5.3/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v4.5.3/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
BREAKING CHANGE: Above components removed from the component library. They will not be exported from this version. resolve #84
add onError callback and error emit, forward params to fallback component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fantastic, this is shaping up well! things like the shimmer states are represented well, but easily adjusted later on.
Could you say more about the spinner SVG in particular, how it was made?
For sure @josh-chamberlain, it's an SVG with two paths, one that holds the inside, and the inner one that does the rotating. Both paths are set to the same color (defaulting to the current element's inherited color value), and the rotation is accomplished with CSS. It takes props for size and color overrides, as well as optional text to be displayed along with the spinner. Pretty basic, but functional. |
🎉 This PR is included in version 2.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Includes