Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: search-v2 #78

Merged
merged 27 commits into from
Jun 10, 2024
Merged

feat: search-v2 #78

merged 27 commits into from
Jun 10, 2024

Conversation

@joshuagraber joshuagraber self-assigned this May 28, 2024
joshuagraber and others added 4 commits June 7, 2024 07:15
BREAKING CHANGE: Above components removed from the component library. They will not be exported from
this version.

resolve #84
add onError callback and error emit, forward params to fallback component
@joshuagraber joshuagraber marked this pull request as ready for review June 7, 2024 15:11
Copy link
Contributor

@josh-chamberlain josh-chamberlain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic, this is shaping up well! things like the shimmer states are represented well, but easily adjusted later on.

Could you say more about the spinner SVG in particular, how it was made?

@joshuagraber
Copy link
Collaborator Author

Could you say more about the spinner SVG in particular, how it was made?

For sure @josh-chamberlain, it's an SVG with two paths, one that holds the inside, and the inner one that does the rotating. Both paths are set to the same color (defaulting to the current element's inherited color value), and the rotation is accomplished with CSS.

It takes props for size and color overrides, as well as optional text to be displayed along with the spinner. Pretty basic, but functional.

@joshuagraber joshuagraber merged commit f454662 into main Jun 10, 2024
7 checks passed
Copy link

🎉 This PR is included in version 2.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants