Add reported but unmodelled benefits #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also added poverty measures (absolute and relative) with references. |
MaxGhenis
reviewed
Sep 23, 2020
| @@ -50,16 +50,33 @@ class family_net_income(Variable): | |||
| definition_period = ETERNITY | |||
|
|
|||
| def formula(family, period, parameters): | |||
| benefits = [ | |||
There was a problem hiding this comment.
Suggested change
| benefits = [ | |
| BENEFITS = [ |
There was a problem hiding this comment.
| @@ -50,16 +50,33 @@ class family_net_income(Variable): | |||
| definition_period = ETERNITY | |||
|
|
|||
| def formula(family, period, parameters): | |||
| benefits = [ | |||
There was a problem hiding this comment.
Could family_net_income and total_benefit_value live somewhere outside the reform directories to be more accessible?
There was a problem hiding this comment.
Ah yeah, that's definitely a good solution - was thinking of something similar because with the current way is a bit inelegant to redefine in reforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds input variables for all other weekly benefits in the FRS, such as Severe Disability Allowance, Maternity Allowance and more bespoke benefits. Also, the linting has been set at 79 characters per line.