Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supplemental Security Income for individuals #596

Merged
merged 30 commits into from
Mar 4, 2022

Conversation

MaxGhenis
Copy link
Contributor

No description provided.

@MaxGhenis
Copy link
Contributor Author

Despite the variety of broken things, I think this is actually fairly close, aside from deeming rules. @nmrodelo

This was linked to issues Feb 27, 2022
@MaxGhenis MaxGhenis mentioned this pull request Mar 3, 2022
@MaxGhenis
Copy link
Contributor Author

I'm lost by the test errors. They seem to be breaking because SSI is person-level instead of SPM unit-level as it was previously, but it's breaking in snap_unearned_income, which calls aggr(spm_unit, period, sources) over a yaml file of all person-level income sources:

    - dividend_income
    - interest_income
    - gi_cash_assistance
    - social_security
    - ssi

@nikhilwoodruff
Copy link
Collaborator

Fixed all the immediate bugs, but left with this policy test:

ssi<2022> >> [0.]
    is_ssi_aged_blind_disabled<2022> >> [False]
      is_ssi_aged<2022> >> [False]
        age<2022> >> [18.]
      is_blind<2022> >> [False]
      is_ssi_disabled<2022> >> [False]
    ssi_countable_resources<2022> >> [0.]
    ssi_countable_income<2022> >> [0.]
      ssi_earned_income<2022> >> [0.]
        employment_income<2022> >> [0.]
        self_employment_income<2022> >> [0.]
      ssi_unearned_income<2022> >> [10.]
        dividend_income<2022> >> [0.]
        interest_income<2022> >> [0.]
        gi_cash_assistance<2022> >> [0.]
        social_security<2022> >> [10.]
          social_security_dependents<2022> >> [1.]
          social_security_disability<2022> >> [2.]
          social_security_retirement<2022> >> [3.]
          social_security_survivors<2022> >> [4.]
      ssi_deemed_income<2022> >> [0.]
F

===================================================================================== FAILURES =====================================================================================
___________________________________________________________________________________ test session ___________________________________________________________________________________
/home/nikhil/policyengine/openfisca-us/openfisca_us/tests/policy/baseline/ssa/social_security.yaml:
  Test 'Social Security sums dependent, disability, retirement, and survivors benefits':
    ssi@2022: [0.] differs from 10.0 with an absolute margin [10.] > 0

@MaxGhenis MaxGhenis marked this pull request as ready for review March 3, 2022 20:42
@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #596 (e2a9e2d) into master (693ffb8) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #596      +/-   ##
==========================================
+ Coverage   96.01%   96.10%   +0.08%     
==========================================
  Files         226      236      +10     
  Lines        5173     5283     +110     
  Branches      562      570       +8     
==========================================
+ Hits         4967     5077     +110     
  Misses        178      178              
  Partials       28       28              
Impacted Files Coverage Δ
..._us/variables/income/spm_unit/spm_unit_benefits.py 100.00% <ø> (ø)
...s/variables/ssa/ssi/eligibility/is_ssi_disabled.py 100.00% <ø> (ø)
...nfisca_us/variables/demographic/person/is_blind.py 100.00% <100.00%> (ø)
...isca_us/variables/demographic/person/is_married.py 100.00% <100.00%> (ø)
..._us/variables/fcc/lifeline/is_lifeline_eligible.py 100.00% <100.00%> (ø)
openfisca_us/variables/ssa/social_security.py 100.00% <100.00%> (ø)
...sca_us/variables/ssa/social_security_dependents.py 100.00% <100.00%> (ø)
...sca_us/variables/ssa/social_security_disability.py 100.00% <100.00%> (ø)
...sca_us/variables/ssa/social_security_retirement.py 100.00% <100.00%> (ø)
...isca_us/variables/ssa/social_security_survivors.py 100.00% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 693ffb8...e2a9e2d. Read the comment docs.

@MaxGhenis MaxGhenis changed the title Supplemental Security Income Supplemental Security Income for individuals Mar 3, 2022
@nikhilwoodruff nikhilwoodruff merged commit ac5b121 into master Mar 4, 2022
@nikhilwoodruff nikhilwoodruff deleted the MaxGhenis/issue594 branch March 4, 2022 10:50
@MaxGhenis MaxGhenis restored the MaxGhenis/issue594 branch March 4, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maximum SSI benefit SSI countable income
2 participants