Improvements to testing infrastructure #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pouljohn1
commented
Jan 12, 2018
pouljohn1
commented
- Added peripheral delegate provider to prevent delegate stealing ([5.0] Prevention from stealing delegates between Peripheral instances, way to (re-)attach delegate. #163)
- Fixed not passing central manager delegate in constructor
- Code generation improvements - now delegate wrappers are also mocks, not testable classes
- Added peripheral delegate provider to prevent delegate stealing. - Fixed not passing central manager delegate in constructor - Code generation improvements - now delegate wrappers are also mocks, not testable classes
…ipheral and CBCentralManager
Source/CBPeripheral+Uuid.swift
Outdated
| extension CBPeripheral { | ||
| /// There is still no identifier property for macOS, that's why we need to retrieve it by value method | ||
| var uuidIdentifier: UUID? { | ||
| return value(forKey: "identifier") as? NSUUID as UUID? |
There was a problem hiding this comment.
could we write here value(forKey: "identifier") as! NSUUID as UUID so we don't need to force cast uuidIdentifier every time
Cierpliwy
reviewed
Jan 17, 2018
| @@ -65,39 +67,39 @@ public class BluetoothManager { | |||
| init( | |||
| @@ -66,37 +68,30 @@ class _BluetoothManager { | |||
| init( | |||
Cierpliwy
approved these changes
Jan 17, 2018
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.