Documentation update #218
Merged
Documentation update #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pouljohn1
suggested changes
Mar 8, 2018
| ```swift | ||
| manager.rx_state | ||
| manager.observeState | ||
| .startWith(manager.state) | ||
| .filter { $0 == .poweredOn } | ||
| .timeout(3.0, scheduler) | ||
| .take(1) |
There was a problem hiding this comment.
I think this take(1) is not needed. There won't be more than 1 event due to ensure(.poweredOn in CentralManager
There was a problem hiding this comment.
hmm, question is, it is possible that CoreBluetooth will send poweredOn twice?
There was a problem hiding this comment.
hmm, I think CoreBluetooth sends this state each time user re-enable bluetooth in his device
There was a problem hiding this comment.
yeah, but when it sends poweredOn, poweredOff, poweredOn then subscription is disposed due to poweredOff so poweredOn won't be called.
Problem might be when we will receive poweredOn, poweredOn, than without take(1) we will 2x start scanning.
| @@ -73,13 +76,13 @@ public class Peripheral { | |||
| return peripheral.state == .connected | |||
| } | |||
|
|
|||
| /// Current state of `Peripheral` instance described by [CBPeripheralState](https://developer.apple.com/library/ios/documentation/CoreBluetooth/Reference/CBPeripheral_Class/#//apple_ref/c/tdef/CBPeripheralState). | |||
| /// Current state of `Peripheral` instance described by [CBPeripheralState](https://developer.apple.com/documentation/corebluetooth/cbperipheralstate). | |||
minixT
force-pushed
the
feature/documentation
branch
from
d0a1ffb
to
9f76d27
Compare
minixT
force-pushed
the
feature/documentation
branch
from
9f76d27
to
ab90d44
Compare
pouljohn1
approved these changes
Mar 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Readme file and code comments to match api changes.