Feature/plmc 398 add treasury pallet to base runtime should like the one in

[vstam1]

TODO:

• check try-runtime working

Adds the following pallets to base runtime:

• Treasury
• Democracy
• Collective:
  • Council
  • Technical Committee
• Election Phragmen
• Scheduler
• Preimage

Adds pallets to test runtime:

• Election Phragmen

Important changes to custom pallets:

Democracy

• From Reserve/Lock -> Hold/Freeze
• Vote lock maximum from free_balance -> total_balance (allows voting with staked balance)

Election phragmen

• From Reserve/Lock -> Hold/Freeze
• Remove Deposit (reserve) requirement for voting
• Vote lock maximum from free_balance -> total_balance (allows voting with staked balance)
• Introduce vote locking period to lock users once they voted.
  • Config item VotingLockPeriod: Time users are locked for from the moment they vote.
  • Change in vote -> renews the locking period
  • Can only remove themselves as voters after VotingLockPeriod

Other important changes

• Added ToGrowthTreasury struct to both base/test runtime. Implements new OnUnbalanced that works together with the fungibles traits, to allow sending slashed funds in both Elections and Democracy pallet to the treasury.
• Changed fast-gov feature to fast-mode feature.
• Introduced instant-mode for Integration testing.
• Removed try-runtime + benchmark features from integration tests

Treasury Config:

• ApproveOrigin: Either root or unanimous council vote. So either council can directly approve or can be approved via governance.
• RejectOrigin: Either root or >1/2 (5/9) vote. Council majority can reject treasury proposal.

[JuaniRios]

We only fixed the tests to use the new fungible API, but didn't actually write a test where we reserve an amount, and can still vote on that right?

I saw the governance tests on integration-tests but didn't see us using a reserve and then voting, or a reserve and then electing

[vstam1]

We only fixed the tests to use the new fungible API, but didn't actually write a test where we reserve an amount, and can still vote on that right?

I saw the governance tests on integration-tests but didn't see us using a reserve and then voting, or a reserve and then electing

Important thing to note it that we only use reserves in specific places (deposit for treasury proposal for example) and maybe use Holds. We know that Holds and locks/freezes can overlap. Also locks and freezes can be set after reserves, only reserve cannot be used on same tokens that are already locked. However, I will try to write some more comprehensive tests for the specific vote cases in combination with holds etc.

[lrazovic]

Few minor changes needed, but overall looks fine. As soon we are aligned on the runtime config, we can merge this.

[lrazovic]

Following our offline discussion, we have agreed to proceed with merging this.