New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/benchmarks refactor #160
Conversation
@@ -254,7 +257,15 @@ fn base_testnet_genesis( | |||
council: Default::default(), | |||
technical_committee: Default::default(), | |||
democracy: Default::default(), | |||
elections: Default::default(), | |||
elections: ElectionsConfig { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A genesis config is required to start the benchmarks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR lays the groundwork for properly benchmarking our runtime.
WeightInfo
config parameter within thedefine_benchmarks!
macro. This inclusion allows us to start the benchmark using the node compiled with theruntime-benchmarks
feature.just
command for executing the benchmarks has been made generic to the pallet's name. For instance, executingjust benchmark-runtime pallet-proxy
allows us to benchmarkpallet-proxy.
Any pallet that is part of thedefine_benchmarks!
macro can be benchmarked using this command.pallet-elections-phragmen
. To address this:polimec-node/pallets/elections-phragmen/src/benchmarking.rs
Line 32 in a7928b7