Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extrinsic to set balance #569

Merged
merged 8 commits into from Oct 11, 2022
Merged

Extrinsic to set balance #569

merged 8 commits into from Oct 11, 2022

Conversation

nakul1010
Copy link
Contributor

@nakul1010 nakul1010 commented Oct 6, 2022

Closes issue #562

@nakul1010 nakul1010 added the A3-InProgress Pull request is in progress. No review needed at this stage. label Oct 6, 2022
@nakul1010 nakul1010 self-assigned this Oct 6, 2022
@nakul1010 nakul1010 changed the base branch from main-net-runtime to Develop October 6, 2022 12:52
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Base: 81.01% // Head: 55.34% // Decreases project coverage by -25.67% ⚠️

Coverage data is based on head (06fc040) compared to base (5f1a405).
Patch coverage: 90.90% of modified lines in pull request are covered.

❗ Current head 06fc040 differs from pull request most recent head b0a147a. Consider uploading reports for the commit b0a147a to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           Develop     #569       +/-   ##
============================================
- Coverage    81.01%   55.34%   -25.68%     
============================================
  Files           28       20        -8     
  Lines         3314     1366     -1948     
============================================
- Hits          2685      756     -1929     
+ Misses         629      610       -19     
Impacted Files Coverage Δ
pallets/ocex/src/lib.rs 77.64% <90.90%> (+0.30%) ⬆️
runtime/src/impls.rs 0.00% <0.00%> (ø)
pallets/ocex/src/tests.rs
pallets/asset-handler/src/mock.rs
pallets/chainbridge/src/tests.rs
pallets/chainbridge/src/mock.rs
pallets/pdex-migration/src/mock.rs
pallets/ocex/src/mock.rs
pallets/pdex-migration/src/tests.rs
pallets/asset-handler/src/tests.rs

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nakul1010 nakul1010 linked an issue Oct 6, 2022 that may be closed by this pull request
@nakul1010
Copy link
Contributor Author

The 536 PR on the orderbook side needs to be merged simultaneously to make sure the primitives version used in the node and orderbook branch are in sync.

@nakul1010 nakul1010 added A0-PleaseReview Pull request needs code review. and removed A3-InProgress Pull request is in progress. No review needed at this stage. labels Oct 10, 2022
Copy link
Contributor

@serhii-temchenko serhii-temchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update related issue with proper description. There I can see one - in the implementation I see another...

node/Cargo.toml Outdated Show resolved Hide resolved
pallets/asset-handler/rpc/Cargo.toml Outdated Show resolved Hide resolved
pallets/asset-handler/rpc/runtime-api/Cargo.toml Outdated Show resolved Hide resolved
pallets/ocex/Cargo.toml Outdated Show resolved Hide resolved
runtime/Cargo.toml Outdated Show resolved Hide resolved
@nakul1010
Copy link
Contributor Author

nakul1010 commented Oct 11, 2022

@serhii-temchenko Created a tag polkadot-v0.9.28v0.1.6 in primitives and updated it in all files

pallets/ocex/src/lib.rs Show resolved Hide resolved
pallets/ocex/src/lib.rs Show resolved Hide resolved
Gauthamastro
Gauthamastro previously approved these changes Oct 11, 2022
Gauthamastro
Gauthamastro previously approved these changes Oct 11, 2022
pallets/ocex/src/tests.rs Outdated Show resolved Hide resolved
@Gauthamastro Gauthamastro merged commit 18a5d7d into Develop Oct 11, 2022
@Gauthamastro Gauthamastro deleted the nap-set-balance branch October 11, 2022 13:57
@serhii-temchenko serhii-temchenko mentioned this pull request Oct 20, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-PleaseReview Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extrinsic to Set Balances
3 participants