Remove old ingress messages and add NoOpConnector for Dev mode #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Gauthamastro
commented
Apr 20, 2023
•
Gauthamastro
commented
- Removes unwanted ingress message
- Adds NoOpConnector for Thea for --dev mode
- Store worker nonce on snapshot
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## Develop #723 +/- ##
===========================================
- Coverage 48.11% 48.07% -0.04%
===========================================
Files 65 64 -1
Lines 4951 4965 +14
===========================================
+ Hits 2382 2387 +5
- Misses 2569 2578 +9
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
| ChainType::Development => Connector { connector: Arc::new(NoOpConnector) }, | ||
| _ => Connector { | ||
| connector: Arc::new( | ||
| ParachainClient::connect("ws://127.0.0.1:9945".to_string()) |
There was a problem hiding this comment.
As mentioned here - I think such values should not be hardcoded.
| connector: Arc<dyn ForeignConnector>, | ||
| } | ||
|
|
||
| pub async fn get_connector(chain_type: ChainType) -> Connector { |
There was a problem hiding this comment.
Semantically more proper name would be - resolve_connector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.