Gj thea client #709
Merged
Gj thea client #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Describe your changes * Fixed todos and added claim_deposit ext. * Added test cases.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## Develop #709 +/- ##
===========================================
- Coverage 52.05% 47.16% -4.90%
===========================================
Files 64 65 +1
Lines 5246 4942 -304
===========================================
- Hits 2731 2331 -400
- Misses 2515 2611 +96
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
| #![cfg_attr(not(feature = "std"), no_std)] | ||
| #![allow(clippy::unused_unit)] | ||
| #![deny(unused_crate_dependencies)] |
There was a problem hiding this comment.
To keep deps list clean - I think this should be present and unused dependencies - removed
Comment on lines
+44
to
+45
| bls-primitives = {path = "primitives/bls-primitives", default-features = false} | ||
| thea-primitives = {path = "primitives/thea", default-features = false} |
| serde = "1.0.152" | ||
| serde_json = "1.0.94" | ||
| tokio = "1.26.0" | ||
| tokio-stream = {version="0.1.12", features = ["time"]} |
| sp-tracing = { git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.37" } | ||
|
|
||
| [dev-dependencies] | ||
| substrate-test-runtime-client = {git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.37" } |
| @@ -0,0 +1,122 @@ | |||
| use std::time::Duration; | |||
There was a problem hiding this comment.
Module level documentation
| ] | ||
| "sp-runtime/std", | ||
| "polkadex-primitives/std" | ||
| ] |
There was a problem hiding this comment.
Empty line at the end of file
Comment on lines
+11
to
+13
| sp-api = { workspace = true, default-features = false } | ||
| sp-std = { workspace = true, default-features = false } | ||
| sp-runtime = { workspace = true, default-features = false } |
Comment on lines
+21
to
+29
| #[derive(Encode, Decode, Clone, Debug, TypeInfo, PartialEq, Eq)] | ||
| pub struct ApprovedWithdraw { | ||
| pub asset_id: u128, | ||
| pub amount: u128, | ||
| pub network: u8, | ||
| pub beneficiary: Vec<u8>, | ||
| pub payload: Vec<u8>, | ||
| pub index: u32, | ||
| } |
| @@ -0,0 +1,145 @@ | |||
| #![cfg_attr(not(feature = "std"), no_std)] | |||
There was a problem hiding this comment.
Crate level documentation
Comment on lines
+8
to
+18
| pub struct Message { | ||
| pub block_no: u64, | ||
| pub nonce: u64, | ||
| pub data: Vec<u8>, | ||
| // Message originated from this network | ||
| pub network: Network, | ||
| pub is_key_change: bool, | ||
| // ValidatorSetId at which this message was executed. | ||
| pub validator_set_id: ValidatorSetId, | ||
| pub validator_set_len: u64, | ||
| } |
This was referenced Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist before requesting a review