Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iv thea message handler tests #825

Merged
merged 19 commits into from
Jul 3, 2023
Merged

Conversation

35359595
Copy link
Contributor

@35359595 35359595 commented Jun 27, 2023

Describe your changes

  • thea-message-handler pallet tests, mocks and fixtures shared with benchmarks for consistancy;
  • added benchmark for update_outgoing_nonce extrinsic;
  • generated new Weights on target machine;

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • I removed all Clippy and Formatting Warnings.
  • I added required Copyrights.

@35359595 35359595 self-assigned this Jun 28, 2023
@35359595 35359595 added the A0-PleaseReview Pull request needs code review. label Jun 28, 2023
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch coverage: 45.45% and project coverage change: +1.21 🎉

Comparison is base (bc57886) 34.47% compared to head (0105ae6) 35.68%.

Additional details and impacted files
@@             Coverage Diff             @@
##           Develop     #825      +/-   ##
===========================================
+ Coverage    34.47%   35.68%   +1.21%     
===========================================
  Files           64       65       +1     
  Lines         4418     4444      +26     
===========================================
+ Hits          1523     1586      +63     
+ Misses        2895     2858      -37     
Impacted Files Coverage Δ
pallets/thea-message-handler/src/benchmarking.rs 0.00% <ø> (ø)
pallets/thea-message-handler/src/weights.rs 0.00% <0.00%> (ø)
runtime/src/impls.rs 0.00% <ø> (ø)
pallets/thea-message-handler/src/lib.rs 58.69% <50.00%> (+58.69%) ⬆️
pallets/thea-message-handler/src/fixtures.rs 75.00% <75.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

runtime/src/impls.rs Show resolved Hide resolved
@Gauthamastro Gauthamastro merged commit 36fce51 into Develop Jul 3, 2023
3 checks passed
@Gauthamastro Gauthamastro deleted the iv-thea-message-handler-tests branch July 3, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-PleaseReview Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants