Gj/on chain validation #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Describe your changes validation for disputes
Gauthamastro
force-pushed
the
gj/on-chain-validation
branch
from
7cd2a39
to
474bd99
Compare
Use of `Percent` and constant majority value instead of saturated arithmetic.
serhii-temchenko
requested changes
Jul 19, 2023
| // You should have received a copy of the GNU General Public License | ||
| // along with this program. If not, see <https://www.gnu.org/licenses/>. | ||
|
|
||
| //! Contains common/reusable functionality. |
There was a problem hiding this comment.
Still no changes?
35359595
suggested changes
Jul 19, 2023
* clone of each deposit for store and dispose instead of full deposits vec cloning; * combined logic for deposit processing and fees collected only if there are deposits; * logs levels demoted to debug from info in ocex pallet;
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## Develop #835 +/- ##
===========================================
- Coverage 40.96% 38.73% -2.24%
===========================================
Files 48 47 -1
Lines 2707 2822 +115
===========================================
- Hits 1109 1093 -16
- Misses 1598 1729 +131
☔ View full report in Codecov by Sentry. |
|
Looks good. Waiting on devops team reply and weights update... |
serhii-temchenko
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Update the parachain port location to 8844 in Thea after testnet testing.