-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weights update #841
Weights update #841
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## Develop #841 +/- ##
===========================================
- Coverage 38.87% 38.69% -0.18%
===========================================
Files 47 47
Lines 2822 2835 +13
===========================================
Hits 1097 1097
- Misses 1725 1738 +13
☔ View full report in Codecov by Sentry. |
In the process of weight generation I noticed that some benchmarks were missed in PR #835 but were added by @zktony in PR #836. So I copy/pasted them in this PR but couldn't build for weights update. I got this error: @zktony could you please check and fix this so I could finish weights update process? |
Currently we have an error while generating weights for some pallets:
Was decided to fix that before weights update so now this PR is on hold until that error will be fixed. |
It's fixed now. Please proceed. |
Describe your changes
After merge of PR #835, weights should be updated.
Issue ticket number and link
#840
Checklist before requesting a review