Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weights update #841

Merged
merged 9 commits into from
Jul 23, 2023
Merged

Weights update #841

merged 9 commits into from
Jul 23, 2023

Conversation

serhii-temchenko
Copy link
Contributor

Describe your changes

After merge of PR #835, weights should be updated.

Issue ticket number and link

#840

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • I removed all Clippy and Formatting Warnings.
  • I added required Copyrights.

@serhii-temchenko serhii-temchenko added the A3-InProgress Pull request is in progress. No review needed at this stage. label Jul 21, 2023
@serhii-temchenko serhii-temchenko self-assigned this Jul 21, 2023
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.18 ⚠️

Comparison is base (c15d0ba) 38.87% compared to head (d33b924) 38.69%.

Additional details and impacted files
@@             Coverage Diff             @@
##           Develop     #841      +/-   ##
===========================================
- Coverage    38.87%   38.69%   -0.18%     
===========================================
  Files           47       47              
  Lines         2822     2835      +13     
===========================================
  Hits          1097     1097              
- Misses        1725     1738      +13     
Impacted Files Coverage Δ
pallets/liquidity/src/weights.rs 0.00% <0.00%> (ø)
pallets/ocex/src/weights.rs 0.00% <0.00%> (ø)
pallets/thea-executor/src/weights.rs 0.00% <0.00%> (ø)
pallets/thea-message-handler/src/benchmarking.rs 0.00% <0.00%> (ø)
pallets/thea-message-handler/src/weights.rs 0.00% <0.00%> (ø)
pallets/thea/src/benchmarking.rs 0.00% <0.00%> (ø)
pallets/thea/src/lib.rs 61.81% <0.00%> (ø)
pallets/thea/src/weights.rs 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@serhii-temchenko
Copy link
Contributor Author

In the process of weight generation I noticed that some benchmarks were missed in PR #835 but were added by @zktony in PR #836. So I copy/pasted them in this PR but couldn't build for weights update. I got this error:

image

@zktony could you please check and fix this so I could finish weights update process?

@serhii-temchenko
Copy link
Contributor Author

serhii-temchenko commented Jul 21, 2023

Currently we have an error while generating weights for some pallets:

Deposit Failed : Module(ModuleError { index: 44, error: [3, 0, 0, 0], message: Some("FailedToDecode") }

Was decided to fix that before weights update so now this PR is on hold until that error will be fixed.

@Gauthamastro
Copy link
Member

Currently we have an error while generating weights for some pallets:

Deposit Failed : Module(ModuleError { index: 44, error: [3, 0, 0, 0], message: Some("FailedToDecode") }

Was decided to fix that before weights update so now this PR is on hold until that error will be fixed.

It's fixed now. Please proceed.

@serhii-temchenko serhii-temchenko added A0-PleaseReview Pull request needs code review. and removed A3-InProgress Pull request is in progress. No review needed at this stage. labels Jul 22, 2023
@Gauthamastro Gauthamastro merged commit 1105c9f into Develop Jul 23, 2023
3 checks passed
@Gauthamastro Gauthamastro deleted the 840/weights-generation branch July 23, 2023 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-PleaseReview Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants