Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch: Commented unsafe checker #868

Merged
merged 9 commits into from
Sep 13, 2023
Merged

Patch: Commented unsafe checker #868

merged 9 commits into from
Sep 13, 2023

Conversation

zktony
Copy link
Contributor

@zktony zktony commented Sep 7, 2023

Describe your changes

Patch: Commented unsafe checker

@zktony zktony changed the base branch from mainnet-release to Develop September 7, 2023 08:56
@Gauthamastro Gauthamastro added the A0-PleaseReview Pull request needs code review. label Sep 7, 2023
@Gauthamastro
Added logs for checkpoint handler (#867)
a4187f4 
## Describe your changes
Added logs for checkpoint handler.
@Gauthamastro
Fix Deviation RPC
382115c
@codecov
Copy link

codecov bot commented Sep 7, 2023 •
edited

Codecov Report

Patch coverage has no change and project coverage change: -0.18% ⚠️

Comparison is base (679cd4a) 36.47% compared to head (967b9d1) 36.29%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           Develop     #868      +/-   ##
===========================================
- Coverage    36.47%   36.29%   -0.18%     
===========================================
  Files           54       54              
  Lines         3241     3257      +16     
===========================================
  Hits          1182     1182              
- Misses        2059     2075      +16
Files Changed Coverage Δ
pallets/ocex/rpc/src/lib.rs 0.00% <0.00%> (ø)
pallets/ocex/src/lib.rs 69.03% <0.00%> (-0.23%) ⬇️
pallets/ocex/src/validator.rs 6.27% <0.00%> (-0.22%) ⬇️
primitives/orderbook/src/recovery.rs 0.00% <0.00%> (ø)
runtime/src/lib.rs 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@serhii-temchenko serhii-temchenko added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Sep 7, 2023
serhii-temchenko
serhii-temchenko requested changes Sep 7, 2023
View reviewed changes
primitives/orderbook/src/recovery.rs Show resolved Hide resolved
scripts/check_deviation.sh Outdated Show resolved Hide resolved
pallets/ocex/rpc/src/lib.rs Outdated Show resolved Hide resolved
pallets/ocex/src/validator.rs Outdated Show resolved Hide resolved
@zktony zktony added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Sep 10, 2023
serhii-temchenko
serhii-temchenko reviewed Sep 11, 2023
View reviewed changes
Copy link
Contributor

@serhii-temchenko serhii-temchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI should be fixed after merge of PR #869.
Will approve after merge of that PR and re-run and success pass of the CI here.

@serhii-temchenko serhii-temchenko added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Sep 11, 2023
@serhii-temchenko serhii-temchenko merged commit dbda2b2 into Develop Sep 13, 2023
3 checks passed
@serhii-temchenko serhii-temchenko deleted the zk-patch-rpc branch September 13, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauthamastro Gauthamastro Gauthamastro approved these changes

@serhii-temchenko serhii-temchenko serhii-temchenko approved these changes

Assignees

@zktony zktony

Labels
A0-PleaseReview Pull request needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zktony @Gauthamastro @serhii-temchenko