Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed CI by changing taplo installation method #869

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Conversation

serhii-temchenko
Copy link
Contributor

Describe your changes

After compiler version update - on attempt of taplo installation with command cargo install taplo-cli we received multiple errors:

error[E0308]: mismatched types
   --> /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/taplo-common-0.4.1/src/schema/mod.rs:555:29
    |
555 | ...                   Arc::try_unwrap(schema).unwrap()
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `&Value`, found `Value`
    |
note: return type inferred to be `&serde_json::Value` here
   --> /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/taplo-common-0.4.1/src/schema/mod.rs:507:13
    |
507 |             return;
    |             ^^^^^^
help: consider borrowing here
    |
555 |                             &Arc::try_unwrap(schema).unwrap()
    |                             +

error[E0308]: mismatched types
   --> /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/taplo-common-0.4.1/src/schema/mod.rs:557:29
    |
557 | ...                   all_of.clone()
    |                       ^^^^^^^^^^^^^^ expected `&Value`, found `Value`
    |
note: return type inferred to be `&serde_json::Value` here
   --> /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/taplo-common-0.4.1/src/schema/mod.rs:507:13
    |
507 |             return;
    |             ^^^^^^
help: try removing the method call
    |
557 -                             all_of.clone()
557 +                             all_of
    |

error[E0308]: mismatched types
   --> /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/taplo-common-0.4.1/src/schema/mod.rs:562:37
    |
562 |                 merged_all_of.merge(schema);
    |                               ----- ^^^^^^ expected `&Value`, found `Value`
    |                               |
    |                               arguments to this method are incorrect
    |
note: method defined here
   --> /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/json_value_merge-1.2.0/src/lib.rs:9:8
    |
9   |     fn merge(&mut self, new_value: &Value);
    |        ^^^^^
help: consider borrowing here
    |
562 |                 merged_all_of.merge(&schema);
    |                                     +

For more information about this error, try `rustc --explain E0308`.
error: could not compile `taplo-common` (lib) due to 3 previous errors
warning: build failed, waiting for other jobs to finish...
error: failed to compile `taplo-cli v0.8.1`, intermediate artifacts can be found at `/tmp/cargo-installuTB8rU`.
To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.
Error: Process completed with exit code 101.

To fix this issue - used alternative method of installation with already pre-compiled binary (link).

Issue ticket number and link

No issue

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • I removed all Clippy and Formatting Warnings.
  • I added required Copyrights.

@serhii-temchenko serhii-temchenko added the A0-PleaseReview Pull request needs code review. label Sep 10, 2023
@serhii-temchenko serhii-temchenko self-assigned this Sep 10, 2023
@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c81ae05) 36.47% compared to head (ca2961d) 36.47%.

Additional details and impacted files
@@           Coverage Diff            @@
##           Develop     #869   +/-   ##
========================================
  Coverage    36.47%   36.47%           
========================================
  Files           54       54           
  Lines         3241     3241           
========================================
  Hits          1182     1182           
  Misses        2059     2059           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zktony zktony merged commit 679cd4a into Develop Sep 11, 2023
3 checks passed
@zktony zktony deleted the fix/no-ref/ci-fix branch September 11, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-PleaseReview Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants