Update to 0.9.43 #27
Closed
Update to 0.9.43 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmikolajczyk41
approved these changes
Jun 27, 2023
|
oh, I see: |
fbielejec
reviewed
Jun 27, 2023
| @@ -16,7 +16,6 @@ services: | |||
| - NODE_KEY_FILE=/data/$NODE01_ACCOUNT_ID/p2p_secret.txt | |||
| - PORT=30333 | |||
| - RPC_PORT=9933 | |||
| - WS_PORT=9944 | |||
There was a problem hiding this comment.
is both the http and ws connectivity now on the same port in this Substarte version? If yes then:
- make sure the first node (the one that exposes and binds ports to the host) uses whatever default ports the tools such as contracts-ui or polkadot/js wallet expect (this used to be a websocket on port 9944)
- remove the port that is not needed from the exposed and from the host mapping section
There was a problem hiding this comment.
There was a problem hiding this comment.
The default is now 9944 for both http and ws. Explained in paritytech/substrate#12663 (comment) and confirmed by my own testing.
fbielejec
reviewed
Jun 27, 2023
fbielejec
reviewed
Jun 27, 2023
fbielejec
reviewed
Jun 27, 2023
fbielejec
reviewed
Jun 27, 2023
CI test fails because of the port change - the curl requests that ping the node should now be using the joint rpc/ws port 9944 |
|
Oops, forgot about this one. I've already updated it quite a bit more. I did break the ci big time though. I'll come back to that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Substrate dependency to
polkadot-v0.9.43.