Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

rpc server: break legacy CLI options and remove "backward compatible HTTP server" #13384

Merged
merged 29 commits into from
May 3, 2023
Merged

rpc server: break legacy CLI options and remove "backward compatible HTTP server" #13384

merged 29 commits into from
May 3, 2023

Conversation

niklasad1
Copy link
Member

@niklasad1 niklasad1 commented Feb 14, 2023 •
edited

Close #13049 #13561

The CLI options that are removed/or renamed are:

  1. --rpc--max--payload (replaced by --rpc--max-request-size and --rpc-max-response-size)
  2. --ws--max--out-buffer-capacity
  3. --ws-external (replaced by --rpc_external)
  4. --unsafe--ws--external (replaced by --unsafe-rpc-external)
  5. --ipc--path
  6. --ws-port (replaced by --rpc--port)
  7. --ws-max--connections (replaced by --rpc--max--connections)
  8. --rpc-http (replaced by --rpc-addr)
  9. --rpc-ws (replaced by --rpc-addr)

polkadot companion: paritytech/polkadot#6987

cumulus companion: paritytech/cumulus#2417

@niklasad1 niklasad1 added A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. B1-note_worthy Changes should be noted in the release notes T0-node This PR/Issue is related to the topic “node”. labels Feb 14, 2023
@niklasad1 niklasad1 changed the title rpc server: break legacy CLI options and remove HTTP server rpc server: break legacy CLI options and remove "backward compatible HTTP server" Feb 14, 2023
@niklasad1 niklasad1 mentioned this pull request Mar 9, 2023
Closed
2 tasks
@stale
Copy link

stale bot commented Mar 18, 2023

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A3-stale label Mar 18, 2023
@niklasad1
Copy link
Member Author

not stale

@stale stale bot removed the A3-stale label Mar 20, 2023
@niklasad1 niklasad1 requested review from bkchr and lexnv March 20, 2023 08:59
@bkchr bkchr mentioned this pull request Mar 29, 2023
Closed
bkchr
bkchr approved these changes Mar 30, 2023
View reviewed changes
client/cli/src/commands/run_cmd.rs Outdated Show resolved Hide resolved
client/service/src/lib.rs Outdated Show resolved Hide resolved
client/service/src/lib.rs Outdated Show resolved Hide resolved
@niklasad1 niklasad1 mentioned this pull request Aug 24, 2023
Open
2 tasks
@kamilsa kamilsa mentioned this pull request May 12, 2023
Closed
@svyatonik svyatonik mentioned this pull request May 17, 2023
Merged
@d-roak d-roak mentioned this pull request May 30, 2023
Merged
@dakk dakk mentioned this pull request Jun 14, 2023
Closed
This was referenced Jun 14, 2023
Closed
Closed
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Closed
@nazar-pc nazar-pc mentioned this pull request Jun 16, 2023
Merged
1 task
@kiltbot kiltbot mentioned this pull request Jun 21, 2023
Closed
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
DaMandal0rian added a commit to subspace/infra that referenced this pull request Jun 24, 2023
@DaMandal0rian
network changes
ea3fc32 
- update devnet and gemini-3d snapshots
- remove system domain
- changes to node to be compatible with upstream changes paritytech/substrate#13384
@DaMandal0rian DaMandal0rian mentioned this pull request Jun 24, 2023
Closed
@JoshOrndorff JoshOrndorff mentioned this pull request Jun 27, 2023
Closed
@DaMandal0rian DaMandal0rian mentioned this pull request Jun 29, 2023
Merged
1 task
@jasl jasl mentioned this pull request Jun 30, 2023
Merged
@Agusrodri Agusrodri mentioned this pull request Jul 4, 2023
Merged
1 task
@gdethier gdethier mentioned this pull request Jul 5, 2023
Merged
AurevoirXavier added a commit to darwinia-network/darwinia that referenced this pull request Jul 11, 2023
@AurevoirXavier
Companion of paritytech/substrate#13384
a4d6012
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@niklasad1 @bkchr
@dmitry-markin @pepoviola @nathanwhit
rpc server: break legacy CLI options and remove "backward compatible …
e02c6a6 
…HTTP server" (paritytech#13384)

* jsonrpsee v0.16

* breaking: remove old CLI configs

* remove patch.crates-io

* fix bad merge

* fix clippy

* fix bad merge

* fix grumbles

* Update client/service/src/lib.rs

Co-authored-by: Bastian Köcher <git@kchr.de>

* revert block_in_place

* add issue link in todo

* Update client/cli/src/config.rs

Co-authored-by: Dmitry Markin <dmitry@markin.tech>

* grumbles: add ipv6 loopback address

* Revert "grumbles: add ipv6 loopback address"

This reverts commit 3a0b1ec.

* remove nits

* bump zombienet version

* adress grumbles: provide structopt default_val_t

* remove duplicate from structopt

* bump zombienet v1.3.47

* bump zombienet version

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Dmitry Markin <dmitry@markin.tech>
Co-authored-by: Javier Viola <javier@parity.io>
@Dinonard Dinonard mentioned this pull request Jul 19, 2023
Merged
16 tasks
@tksarah tksarah mentioned this pull request Aug 1, 2023
Closed
@pepoviola pepoviola mentioned this pull request Aug 3, 2023
Open
@vikinatora vikinatora mentioned this pull request Aug 16, 2023
Closed
@bkchr bkchr mentioned this pull request Aug 21, 2023
Closed
@ToufeeqP ToufeeqP mentioned this pull request Aug 31, 2023
Merged
@eshaben eshaben mentioned this pull request Sep 6, 2023
Merged
2 tasks
@pfrank13 pfrank13 mentioned this pull request Sep 30, 2023
Merged
@samelamin samelamin mentioned this pull request Oct 18, 2023
Merged
@mattdean-digicatapult mattdean-digicatapult mentioned this pull request Jan 4, 2024
Merged
@gracecampo gracecampo mentioned this pull request Jan 18, 2024
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

@koute koute koute approved these changes

@melekes melekes melekes approved these changes

@dmitry-markin dmitry-markin dmitry-markin approved these changes

@alvicsam alvicsam alvicsam approved these changes

@sergejparity sergejparity sergejparity approved these changes

@lexnv lexnv Awaiting requested review from lexnv

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove HTTP RPC server and remove outdated CLI options.
8 participants
@niklasad1 @pepoviola @koute @melekes @bkchr @dmitry-markin @alvicsam @sergejparity