Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker containers to address singularity path issue for maven repo #86

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

sameeul
Copy link
Member

@sameeul sameeul commented Jul 16, 2024

No description provided.

@sameeul sameeul requested a review from vjaganat90 July 18, 2024 12:11
@sameeul sameeul changed the title Update docker containers to address singularity path issue for mave repo Update docker containers to address singularity path issue for maven repo Jul 18, 2024
Copy link
Member

@vjaganat90 vjaganat90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall.

RUN python3 -c 'import bfio; bfio.start()'
RUN python3 -c 'import imagej; ij = imagej.init(); print(ij.getVersion())'

# Set the correct permissions again, for sanity
RUN chmod -R 777 /etc/m2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not clear why you have to set the permissions again? (similar in other dockerfiles)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once we run line 67, new files get added to /etc/m2. I just want to be absolutely sure that all the new files can be read, and executed by any user.

@sameeul sameeul merged commit 6834b16 into PolusAI:master Jul 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants