Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single-Trade Volume Restriction Module Development Task #258

Closed
CPSTL opened this issue Sep 13, 2018 · 14 comments
Closed

Single-Trade Volume Restriction Module Development Task #258

CPSTL opened this issue Sep 13, 2018 · 14 comments
Labels
Module development Used when new module is created open-source community Something suggest or developed by external developers

Comments

@CPSTL
Copy link
Contributor

CPSTL commented Sep 13, 2018 •
edited by satyamakgec
Loading

Single-Trade Volume Restriction Module

Module Type Bounty Completion deadline
Transfer Manager 3,000-5,000 POLY 14 days starting the day of task acceptance

Bounty Requirements

  1. Module specs are fulfilled
  2. Module is implemented using appropriate module interface
  3. Module is tested with >95% branch coverage
  4. Module is delivered before deadline

Module Specs

  1. Limit number of tokens which can be sent per transaction to a pre-defined limit. Revert if above limit.
  2. Exempt special-use wallets from this volume restriction per trade.
  3. Issuer should be able to set global limit for all addresses and set custom limit for each address.
  4. Issuer should be able to change limit at any time.
  5. Any state changes should emit an appropriate event.

Assumptions

  1. This volume restriction can operate in conjunction with all existing transfer restrictions and volume restrictions
  2. Restrictions applies to all wallets by default
  3. Some wallets (e.g. Treasury wallet, or Vesting wallet) may be subject to an exemption
  4. Activation and/or Configuration of the "Single-Trade Volume Restriction" may be performed by an Authorized Employee of the Company or a Delegated Authority, such as a Transfer Agent
  5. One or more Wallet addresses can be granted the privilege of managing the Single-Trade Volume Restriction.

Detailed Module Specs

https://www.lucidchart.com/documents/view/ffbc99b9-a2d2-4043-8847-2bd0182aac3c

NOTE: It would be ideal if the developer taking on this task could work on the single-trade vol restrictions from the development-1.5.0 branch instead of master.
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 5000.0 POLY attached to it.

@subramanianv subramanianv mentioned this issue Sep 18, 2018
Closed
3 tasks
@CPSTL
Copy link
Contributor Author

CPSTL commented Sep 18, 2018

Hello @subramanianv! Would it be possible for you to work on the single-trade vol restrictions from the development-1.5.0 branch instead of master?

@gitcoinbot
Copy link

gitcoinbot commented Sep 19, 2018 •
edited
Loading

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 4 months, 3 weeks ago.
Please review their action plans below:

1) subramanianv has started work.

I will going through the STToken and also the Modules Interface

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

@subramanianv Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@subramanianv
Copy link

subramanianv commented Sep 22, 2018 via email

@satyamakgec satyamakgec added Module development Used when new module is created open-source community Something suggest or developed by external developers labels Sep 22, 2018
@gitcoinbot
Copy link

@atul3940 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@CPSTL
Copy link
Contributor Author

CPSTL commented Sep 24, 2018

@subramanianv Hello, do you have an update on this issue for us?

@subramanianv
Copy link

subramanianv commented Sep 24, 2018 via email

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 5000.0 POLY (807.0 USD @ $0.16/POLY) has been submitted by:

  1. @subramanianv

@CPSTL please take a look at the submitted work:

@pabloruiz55
Copy link
Contributor

@CPSTL PR has been approved and merged. We are ready to award @subramanianv.
Thanks again for building this module with us @subramanianv ! Looking forward to see you tackling future bounties. 🤗

@subramanianv
Copy link

@pabloruiz55 @satyamakgec Thanks for all the help and patience. Looking forward to work on more bounties in the future

@CPSTL
Copy link
Contributor Author

CPSTL commented Oct 5, 2018

@subramanianv @pabloruiz55 Paid! Thank you for your work :)

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 5000.0 POLY (870.0 USD @ $0.17/POLY) attached to this issue has been approved & issued to @subramanianv.

@satyamakgec
Copy link
Contributor

resolved by PR #262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Module development Used when new module is created open-source community Something suggest or developed by external developers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@pabloruiz55 @subramanianv @satyamakgec @gitcoinbot @CPSTL