Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add versioning in the script into the docs.sh #252

Merged
merged 3 commits into from
Sep 13, 2018

Conversation

satyamakgec
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our Submission guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Bug fixing and minor addition of new features

What is the current behavior?

(You can also link to an open issue here)
#251

What is the new behavior?

(Define and describe any new functionality. Clarify if this is a feature change)
Fix the versioning issue.
Feature of excluding the certain contracts

Does this PR introduce a breaking change?

(What changes might users need to make in their application due to this PR?)
No

Any Other information:

Do not merge it until @sajclarke gives the confirmation that the raised PR on developer-portal works as desired.

@pabloruiz55
Copy link
Contributor

Approved.

@pabloruiz55
Copy link
Contributor

Do not merge it until @sajclarke gives the confirmation that the raised PR on developer-portal works as desired.

@sajclarke / @satyamakgec can this be merged now?

@satyamakgec
Copy link
Contributor Author

Yes we can

@satyamakgec satyamakgec merged commit 7b3e7db into master Sep 13, 2018
@satyamakgec satyamakgec deleted the docs-script-improve branch October 30, 2019 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants