Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Module getters updated #261

Merged
merged 4 commits into from
Sep 17, 2018
Merged

Conversation

VictorVicente
Copy link
Contributor

@VictorVicente VictorVicente commented Sep 17, 2018

Please check if the PR fulfills these requirements

  • The commit message follows our Submission guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

CLI fix

What is the current behavior?

CLI is broken due to #259 changes

What is the new behavior?

CLI is fixed

Does this PR introduce a breaking change?

No

@adamdossa
Copy link
Contributor

@VictorVicente I added some logic for archive / remove & unarchive - please could you review.

@adamdossa adamdossa self-requested a review September 17, 2018 20:25
@adamdossa adamdossa merged commit 615288e into development-1.5.0 Sep 17, 2018
@VictorVicente VictorVicente deleted the remove-max-modules branch September 18, 2018 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants