Add DAI to USDTieredSTO #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
adamdossa
commented
Sep 19, 2018
•
adamdossa
commented
- Added DAI as an accepted currency for USDTieredSTO
- Added daiToken as configuration param to USDTieredSTO
- Updated tests including USDTieredSTO Sim
- Updated CLI to reference new functions
|
@adamdossa PR Looks good to me when all the test cases get passed then I will approve it. |
|
@VictorVicente I made updates to the CLI for the new functions, but I think accepting DAI for USDTieredSTO's will need more changes. We will need to decide what to do on ganache / testnet for DAI (probably easiest is to generate a mocked token, or re-use polyToken (current approach). |
|
@satyamakgec Test cases all run to success - please review. |
satyamakgec
approved these changes
Sep 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.