New poly oracle #274
Merged
New poly oracle #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabloruiz55
reviewed
Sep 21, 2018
| @@ -6,39 +6,57 @@ import "openzeppelin-solidity/contracts/ownership/Ownable.sol"; | |||
|
|
|||
| contract MakerDAOOracle is IOracle, Ownable { | |||
There was a problem hiding this comment.
@adamdossa since we removed all references to MakerDAO in the code, do you want to rename the contract too?
There was a problem hiding this comment.
Think it is OK to leave. This contract will only work w/ MakerDAO deployed Medianizer contracts.
pabloruiz55
reviewed
Sep 21, 2018
pabloruiz55
reviewed
Sep 21, 2018
contracts/oracles/MakerDAOOracle.sol
Outdated
| * @param _medianizer Address of Maker medianizer | ||
| */ | ||
| function changeMedianier(address _medianizer) public onlyOwner { | ||
| emit LogChangeMedianizer(_medianizer, medianizer, now); |
There was a problem hiding this comment.
require _medianizer != address(0)?
|
@satyamakgec FYI - I changed to using an interface for the Medianizer which gets rid of some of the warnings. |
satyamakgec
approved these changes
Sep 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MakerDAOOracle can be reused for multiple oracles (Medianizer contracts)