Check pause flow #285
Merged
Check pause flow #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR looks good. Only wondering why all those commits are showing up in the PR. @satyamakgec |
adamdossa
suggested changes
Sep 27, 2018
contracts/SecurityTokenRegistry.sol
Outdated
| @@ -116,10 +116,15 @@ contract SecurityTokenRegistry is ISecurityTokenRegistry, EternalStorage { | |||
| * @notice Modifier to make a function callable only when the contract is not paused. | |||
| */ | |||
| modifier whenNotPaused() { | |||
There was a problem hiding this comment.
Can you rename to something like whenNotPausedOrOwner - whenNotPaused might be a bit confusing as it's a standard function with a different normal implementation.
contracts/ModuleRegistry.sol
Outdated
| @@ -296,7 +300,7 @@ contract ModuleRegistry is IModuleRegistry, EternalStorage { | |||
| /** | |||
| * @notice Called by the owner to pause, triggers stopped state | |||
| */ | |||
| function pause() external whenNotPaused onlyOwner { | |||
| function pause() external onlyOwner { | |||
There was a problem hiding this comment.
I think pause should revert if the contract is already paused. It makes the logs easier to interpret. Can we have whenNotPaused and whenNotPausedOrOwner and use whenNotPaused here maybe?
|
@pabloruiz55 the cause of showing all other commits was |
adamdossa
approved these changes
Sep 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
(Bug fix, feature, docs update, ...)
What is the current behavior?
(You can also link to an open issue here)
Merge only when the
upgrade-mrPR get merge as I take that upgrade-mr as a base branchWhat is the new behavior?
(Define and describe any new functionality. Clarify if this is a feature change)
Does this PR introduce a breaking change?
(What changes might users need to make in their application due to this PR?)
Any Other information: