-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimise STR #294
Optimise STR #294
Conversation
Please could you carefully review this PR as it fixes some bugs and makes some changes. Previous bug was in This was missed in the test cases, specifically the test case “Should add the new custom ticker” did not correctly record ownership. When we then transferred ownership in “Should change the details of the existing ticker” we actually then transfer the ownership of the wrong token since “ETH” does not have an index in “tickerIndex”. We didn’t catch this in the getter test case “Should get the tickers by owner” as it checked that
|
@satyamakgec Also fixed a few cases where we weren't using the correct upper case ticker value - please could you double check these as well. |
Ah! I miss it, actually the cause of bug was that I focused on solving the |
Also did a small commit to optimize more. |
…k/polymath-core into optimise_str_size
Optimise STR code size & fix modifyTicker bug