VolumeRestrictionTM #421

satyamakgec · 2018-11-20T10:37:31Z

Test suite
Global check
Algorithm optimizations
Adding read functionality using verifyTransfer()

maxsam4 · 2018-12-12T12:16:22Z

Travis failed again while local tests passed
Travis output

4 failing
  1) Contract: VolumeRestrictionTransferManager
       Test cases for the Default restrictions
         Should transfer the tokens freely after ending the default daily restriction:
     Error: VM Exception while processing transaction: revert Transfer invalid
      at Object.InvalidResponse (node_modules/truffle/build/webpack:/~/web3/lib/web3/errors.js:38:1)
      at node_modules/truffle/build/webpack:/~/web3/lib/web3/requestmanager.js:86:1
      at node_modules/truffle/build/webpack:/packages/truffle-provider/wrapper.js:134:1
      at XMLHttpRequest.request.onreadystatechange (node_modules/truffle/build/webpack:/~/web3/lib/web3/httpprovider.js:128:1)
      at XMLHttpRequestEventTarget.dispatchEvent (node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:64:1)
      at XMLHttpRequest._setReadyState (node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:354:1)
      at XMLHttpRequest._onHttpResponseEnd (node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:509:1)
      at IncomingMessage.<anonymous> (node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:469:1)
      at endReadableNT (_stream_readable.js:1064:12)
      at _combinedTickCallback (internal/process/next_tick.js:139:11)
      at process._tickCallback (internal/process/next_tick.js:181:9)
  2) Contract: VolumeRestrictionTransferManager
       Test cases for the Default restrictions
         Should transfer tokens on by investor 3 (comes under the Default restriction):
     Error: VM Exception while processing transaction: revert
      at Object.InvalidResponse (node_modules/truffle/build/webpack:/~/web3/lib/web3/errors.js:38:1)
      at node_modules/truffle/build/webpack:/~/web3/lib/web3/requestmanager.js:86:1
      at node_modules/truffle/build/webpack:/packages/truffle-provider/wrapper.js:134:1
      at XMLHttpRequest.request.onreadystatechange (node_modules/truffle/build/webpack:/~/web3/lib/web3/httpprovider.js:128:1)
      at XMLHttpRequestEventTarget.dispatchEvent (node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:64:1)
      at XMLHttpRequest._setReadyState (node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:354:1)
      at XMLHttpRequest._onHttpResponseEnd (node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:509:1)
      at IncomingMessage.<anonymous> (node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:469:1)
      at endReadableNT (_stream_readable.js:1064:12)
      at _combinedTickCallback (internal/process/next_tick.js:139:11)
      at process._tickCallback (internal/process/next_tick.js:181:9)
  3) Contract: VolumeRestrictionTransferManager
       Test cases for the Default restrictions
         Should able to transfer tokens in the next rolling period:
     Error: VM Exception while processing transaction: revert
      at Object.InvalidResponse (node_modules/truffle/build/webpack:/~/web3/lib/web3/errors.js:38:1)
      at node_modules/truffle/build/webpack:/~/web3/lib/web3/requestmanager.js:86:1
      at node_modules/truffle/build/webpack:/packages/truffle-provider/wrapper.js:134:1
      at XMLHttpRequest.request.onreadystatechange (node_modules/truffle/build/webpack:/~/web3/lib/web3/httpprovider.js:128:1)
      at XMLHttpRequestEventTarget.dispatchEvent (node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:64:1)
      at XMLHttpRequest._setReadyState (node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:354:1)
      at XMLHttpRequest._onHttpResponseEnd (node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:509:1)
      at IncomingMessage.<anonymous> (node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:469:1)
      at endReadableNT (_stream_readable.js:1064:12)
      at _combinedTickCallback (internal/process/next_tick.js:139:11)
      at process._tickCallback (internal/process/next_tick.js:181:9)
  4) Contract: VolumeRestrictionTransferManager
       Test cases for the Default restrictions
         Should able to transfer tokens within the limit of (daily default + default) restriction:
     Error: VM Exception while processing transaction: revert
      at Object.InvalidResponse (node_modules/truffle/build/webpack:/~/web3/lib/web3/errors.js:38:1)
      at node_modules/truffle/build/webpack:/~/web3/lib/web3/requestmanager.js:86:1
      at node_modules/truffle/build/webpack:/packages/truffle-provider/wrapper.js:134:1
      at XMLHttpRequest.request.onreadystatechange (node_modules/truffle/build/webpack:/~/web3/lib/web3/httpprovider.js:128:1)
      at XMLHttpRequestEventTarget.dispatchEvent (node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:64:1)
      at XMLHttpRequest._setReadyState (node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:354:1)
      at XMLHttpRequest._onHttpResponseEnd (node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:509:1)
      at IncomingMessage.<anonymous> (node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:469:1)
      at endReadableNT (_stream_readable.js:1064:12)
      at _combinedTickCallback (internal/process/next_tick.js:139:11)

maxsam4

Let's first figure out why Travis is failing sometimes. Is there an edge case that is time-based and is causing the failure? or is it just Travis being Travis.

maxsam4 · 2018-12-12T12:21:39Z

It's definitely an edge case.
Edge case in either the smart contract code or time travel in test code.

After 6 successful runs, it finally failed on my local. Trying to debug now.
@satyamakgec keep spamming tests till you get an error 📦

below is output from my local. It is different from Travis's last output.

  5 failing

  1) Contract: VolumeRestrictionTransferManager
       Test cases for the Default restrictions
         Should transfer the tokens freely after ending the default daily restriction:
     Error: VM Exception while processing transaction: revert Transfer invalid
      at Object.InvalidResponse (/home/max/.nvm/versions/node/v8.12.0/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/errors.js:38:1)
      at /home/max/.nvm/versions/node/v8.12.0/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/requestmanager.js:86:1
      at /home/max/.nvm/versions/node/v8.12.0/lib/node_modules/truffle/build/webpack:/packages/truffle-provider/wrapper.js:134:1
      at XMLHttpRequest.request.onreadystatechange (/home/max/.nvm/versions/node/v8.12.0/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/httpprovider.js:128:1)
      at XMLHttpRequestEventTarget.dispatchEvent (/home/max/.nvm/versions/node/v8.12.0/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:64:1)
      at XMLHttpRequest._setReadyState (/home/max/.nvm/versions/node/v8.12.0/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:354:1)
      at XMLHttpRequest._onHttpResponseEnd (/home/max/.nvm/versions/node/v8.12.0/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:509:1)
      at IncomingMessage.<anonymous> (/home/max/.nvm/versions/node/v8.12.0/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:469:1)
      at endReadableNT (_stream_readable.js:1064:12)
      at _combinedTickCallback (internal/process/next_tick.js:139:11)
      at process._tickCallback (internal/process/next_tick.js:181:9)

  2) Contract: VolumeRestrictionTransferManager
       Test cases for the Default restrictions
         Should transfer tokens on by investor 3 (comes under the Default restriction):
     Error: VM Exception while processing transaction: revert Transfer invalid
      at Object.InvalidResponse (/home/max/.nvm/versions/node/v8.12.0/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/errors.js:38:1)
      at /home/max/.nvm/versions/node/v8.12.0/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/requestmanager.js:86:1
      at /home/max/.nvm/versions/node/v8.12.0/lib/node_modules/truffle/build/webpack:/packages/truffle-provider/wrapper.js:134:1
      at XMLHttpRequest.request.onreadystatechange (/home/max/.nvm/versions/node/v8.12.0/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/httpprovider.js:128:1)
      at XMLHttpRequestEventTarget.dispatchEvent (/home/max/.nvm/versions/node/v8.12.0/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:64:1)
      at XMLHttpRequest._setReadyState (/home/max/.nvm/versions/node/v8.12.0/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:354:1)
      at XMLHttpRequest._onHttpResponseEnd (/home/max/.nvm/versions/node/v8.12.0/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:509:1)
      at IncomingMessage.<anonymous> (/home/max/.nvm/versions/node/v8.12.0/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:469:1)
      at endReadableNT (_stream_readable.js:1064:12)
      at _combinedTickCallback (internal/process/next_tick.js:139:11)
      at process._tickCallback (internal/process/next_tick.js:181:9)

  3) Contract: VolumeRestrictionTransferManager
       Test cases for the Default restrictions
         Should fail to transfer more tokens than the available default limit:
     AssertionError: Expected an error but did not get one
      at _callee$ (test/helpers/exceptions.js:9:9)
      at tryCatch (node_modules/regenerator-runtime/runtime.js:65:40)
      at Generator.invoke [as _invoke] (node_modules/regenerator-runtime/runtime.js:303:22)
      at Generator.prototype.(anonymous function) [as next] (node_modules/regenerator-runtime/runtime.js:117:21)
      at step (test/helpers/exceptions.js:40:191)
      at test/helpers/exceptions.js:40:361
      at <anonymous>
      at process._tickCallback (internal/process/next_tick.js:189:7)

  4) Contract: VolumeRestrictionTransferManager
       Test cases for the Default restrictions
         Should able to transfer tokens in the next rolling period:
     Error: VM Exception while processing transaction: revert
      at Object.InvalidResponse (/home/max/.nvm/versions/node/v8.12.0/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/errors.js:38:1)
      at /home/max/.nvm/versions/node/v8.12.0/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/requestmanager.js:86:1
      at /home/max/.nvm/versions/node/v8.12.0/lib/node_modules/truffle/build/webpack:/packages/truffle-provider/wrapper.js:134:1
      at XMLHttpRequest.request.onreadystatechange (/home/max/.nvm/versions/node/v8.12.0/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/httpprovider.js:128:1)
      at XMLHttpRequestEventTarget.dispatchEvent (/home/max/.nvm/versions/node/v8.12.0/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:64:1)
      at XMLHttpRequest._setReadyState (/home/max/.nvm/versions/node/v8.12.0/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:354:1)
      at XMLHttpRequest._onHttpResponseEnd (/home/max/.nvm/versions/node/v8.12.0/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:509:1)
      at IncomingMessage.<anonymous> (/home/max/.nvm/versions/node/v8.12.0/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:469:1)
      at endReadableNT (_stream_readable.js:1064:12)
      at _combinedTickCallback (internal/process/next_tick.js:139:11)
      at process._tickCallback (internal/process/next_tick.js:181:9)

  5) Contract: VolumeRestrictionTransferManager
       Test cases for the Default restrictions
         Should able to transfer tokens within the limit of (daily default + default) restriction:

      AssertionError: expected 5 to equal 6
      + expected - actual

      -5
      +6
      
      at _callee79$ (test/y_volume_restriction_tm.js:1448:20)
      at tryCatch (node_modules/regenerator-runtime/runtime.js:65:40)
      at Generator.invoke [as _invoke] (node_modules/regenerator-runtime/runtime.js:303:22)
      at Generator.prototype.(anonymous function) [as next] (node_modules/regenerator-runtime/runtime.js:117:21)
      at step (test/y_volume_restriction_tm.js:23:191)
      at test/y_volume_restriction_tm.js:23:361
      at <anonymous>
      at process._tickCallback (internal/process/next_tick.js:189:7)

…ictions

maxsam4 · 2018-12-21T09:31:08Z

Approved the solidity code

coveralls · 2019-01-03T15:34:42Z

Coverage decreased (-1.5%) to 96.228% when pulling 6354748 on volTM-module into c4a0af6 on dev-2.1.0.

SatyamSB added 4 commits November 16, 2018 11:55

intialise

29ed76d

function declaration

8adb72d

initial draft of VRTM

055d2ac

remove BokkyPooBahsDateTimeLibrary from coverage

6aee799

satyamakgec changed the title ~~VolumeRestrictionTM~~ [WIP]:VolumeRestrictionTM Nov 20, 2018

satyamakgec changed the title ~~[WIP]:VolumeRestrictionTM~~ [WIP]VolumeRestrictionTM Nov 20, 2018

SatyamSB added 5 commits November 20, 2018 17:48

test file addition

f805ad6

allow read using verifyTransfer()

c3de389

refactoring bucket function

eddd5a5

global + individual check added

3455d94

finalised the logic of sc

9f1970d

satyamakgec changed the title ~~[WIP]VolumeRestrictionTM~~ VolumeRestrictionTM Nov 25, 2018

SatyamSB added 6 commits November 25, 2018 16:57

Merge branch 'dev-2.1.0' into volTM-module

18b429f

minor fixes

6126201

reduce the error strings to lower the sixe of the contract

b069122

minor fixes

f44d053

add more test cases

96bf749

Merge branch 'dev-2.1.0' into volTM-module

6597961

satyamakgec requested review from maxsam4 and adamdossa November 26, 2018 08:24

SatyamSB and others added 10 commits November 26, 2018 14:34

remove the reason strings

8e44d1b

minor fixes in the contract

56d0a57

Merge branch 'dev-2.1.0' into volTM-module

c9b90bc

merge dev-2.1.0 and add new test case

2d96fc2

Merge branch 'dev-2.1.0' into volTM-module

c33afd4

test cases fixed

9802d8a

Merge branch 'volTM-module' of https://github.com/PolymathNetwork/pol…

2031c8e

…ymath-core into volTM-module

minor test fix because of gtm

ed94068

update the permission doc

c0878e8

VRTM moved from experimental to usable TM list

0afae26

maxsam4 suggested changes Dec 12, 2018

View reviewed changes

SatyamSB and others added 10 commits December 12, 2018 19:33

trying by adding some buffer in time travel

34efb95

modify function changes

bc0b62e

CLI - WIP VolumeRestrictionTM support

62d4bb5

CLI - Removed STVR TM from CLI

70f6cac

CLI - Operations in batch for VRTM

125c1b8

CLI - Explore account

67d3429

wip - issue with test not finishing

3386072

WIP-multiple transaction within 1 day with Individual and daily Restr…

43cc95a

…ictions

fixed bug with the initial test

4e1e37b

added scenario 2 and 3

2de1bb8

maxsam4 approved these changes Dec 21, 2018

View reviewed changes

comeonbuddy and others added 8 commits December 21, 2018 16:34

fix input random number issue

40343b9

finished test case 4

2148636

WIP

7b7f3ab

WIP

40cfa3d

reinvent the test case

b13e08c

Merge conflicts

1299ca3

Merge branch 'dev-2.1.0' into volTM-module

b7d6df0

Merge branch 'dev-2.1.0' into volTM-module

6354748

VictorVicente merged commit e478aa3 into dev-2.1.0 Jan 3, 2019

VictorVicente deleted the volTM-module branch January 3, 2019 16:30

This was referenced Jan 8, 2019

Module Development Task: Volume Restriction (Maximum Volume Transfer) #267

Closed

Module Development Task: Volume Restriction (Dumping) #268

Closed

knanjukutty-polymath mentioned this pull request Mar 28, 2024

[Snyk] Security upgrade web3-provider-engine from 15.0.0 to 16.0.7 #943

Open

knanjukutty-polymath mentioned this pull request Apr 17, 2024

[Snyk] Fix for 1 vulnerabilities #945

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

VolumeRestrictionTM #421

VolumeRestrictionTM #421

satyamakgec commented Nov 20, 2018 •

edited by VictorVicente

maxsam4 commented Dec 12, 2018

maxsam4 left a comment

maxsam4 commented Dec 12, 2018 •

edited

maxsam4 commented Dec 21, 2018 •

edited

coveralls commented Jan 3, 2019

VolumeRestrictionTM #421

VolumeRestrictionTM #421

Conversation

satyamakgec commented Nov 20, 2018 • edited by VictorVicente

maxsam4 commented Dec 12, 2018

maxsam4 left a comment

Choose a reason for hiding this comment

maxsam4 commented Dec 12, 2018 • edited

maxsam4 commented Dec 21, 2018 • edited

coveralls commented Jan 3, 2019

satyamakgec commented Nov 20, 2018 •

edited by VictorVicente

maxsam4 commented Dec 12, 2018 •

edited

maxsam4 commented Dec 21, 2018 •

edited