Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple stable coins support in USD Tiered STO #437

Merged
merged 42 commits into from
Dec 19, 2018

Conversation

maxsam4
Copy link
Contributor

@maxsam4 maxsam4 commented Nov 27, 2018

Please check if the PR fulfills these requirements

  • The commit message follows our Submission guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

(Bug fix, feature, docs update, ...)
Added Multiple stable coins support in USD Tiered STO

Does this PR introduce a breaking change?

(What changes might users need to make in their application due to this PR?)

  1. An array of stable coin addresses has to be passed now rather than a single stable coin when configuring.
  2. The investor has to provide the stable coin address they want to use when buying tokens with USD.

@maxsam4 maxsam4 changed the base branch from master to dev-2.1.0 November 27, 2018 13:21
@adamdossa
Copy link
Contributor

@maxsam4 Only minor comment is you could consider combining validSC and validUSDToken as I think they'll always be called together.

Otherwise looks good to me, with the caveat that the dApp / CLI will need some minor modifications for this.

contracts/modules/STO/USDTieredSTO.sol Outdated Show resolved Hide resolved
contracts/modules/STO/USDTieredSTO.sol Show resolved Hide resolved
@maxsam4
Copy link
Contributor Author

maxsam4 commented Nov 27, 2018

Thanks @adamdossa
Pushed commit to merge the modifiers. My coding style is still one function one task but that does not work with solidity. Adapting is hard :).

@maxsam4 maxsam4 changed the title [Feature] Multiple stable coins support in USD Tiered STO Multiple stable coins support in USD Tiered STO Nov 28, 2018
@VictorVicente VictorVicente changed the title Multiple stable coins support in USD Tiered STO [WIP] Multiple stable coins support in USD Tiered STO Dec 10, 2018
@VictorVicente VictorVicente changed the title [WIP] Multiple stable coins support in USD Tiered STO Multiple stable coins support in USD Tiered STO Dec 12, 2018
@coveralls
Copy link

coveralls commented Dec 18, 2018

Coverage Status

Coverage increased (+0.005%) to 98.035% when pulling 15d9dcf on multiple-stable-coins into 2336d85 on dev-2.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants