-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MATM changes #450
MATM changes #450
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are looking fine to me.
@comeonbuddy you don't need to remove /*solium-disable-next-line security/no-block-members*/
this from the code it only used for linting :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still need to review logic. Only completed style review currently.
contracts/modules/TransferManager/ManualApprovalTransferManager.sol
Outdated
Show resolved
Hide resolved
contracts/modules/TransferManager/ManualApprovalTransferManager.sol
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, Just some minor things that can be optimized.
Test cases need to be fixed/added.
contracts/modules/TransferManager/ManualApprovalTransferManager.sol
Outdated
Show resolved
Hide resolved
contracts/modules/TransferManager/ManualApprovalTransferManager.sol
Outdated
Show resolved
Hide resolved
contracts/modules/TransferManager/ManualApprovalTransferManager.sol
Outdated
Show resolved
Hide resolved
Edited title and description to include all new MATM changes |
…both will return all approval details in multiple arrays as requested
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Yes
Any Other information: