Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split out ISTO.sol #479

Merged
merged 3 commits into from
Dec 18, 2018
Merged

Split out ISTO.sol #479

merged 3 commits into from
Dec 18, 2018

Conversation

kostind
Copy link
Contributor

@kostind kostind commented Dec 17, 2018

Please check if the PR fulfills these requirements

  • The commit message follows our Submission guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Split out ISTO.sol into an interface file, and an abstract base class.

Any Other information:

maxsam4
maxsam4 reviewed Dec 18, 2018
View reviewed changes
Copy link
Contributor

@maxsam4 maxsam4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

current changes look good to me.
Please also split modules/TransferManager/ITransferManager.sol and move the interfaces to the interface directory.

@kostind
Copy link
Contributor Author

kostind commented Dec 18, 2018

ITransferManager has been split.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 97.963% when pulling d842c20 on Split-out-ISTO into 139a36b on dev-3.0.0.

@satyamakgec satyamakgec merged commit 68f1af9 into dev-3.0.0 Dec 18, 2018
@maxsam4 maxsam4 mentioned this pull request Feb 5, 2019
Merged
@satyamakgec satyamakgec deleted the Split-out-ISTO branch October 30, 2019 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxsam4 maxsam4 maxsam4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kostind @coveralls @maxsam4 @satyamakgec