Use the editor service npm module directly #40
Conversation
rictic
commented
Nov 11, 2016
rictic
commented
- CHANGELOG.md has not been updated, as this is an entirely internal change.
| @@ -16,7 +16,8 @@ | |||
| "dependencies": { | |||
| "@types/node": "^6.0.41", | |||
| "marked": "^0.3.6", | |||
| "polymer-analyzer": "^2.0.0-alpha.15" | |||
| "polymer-analyzer": "=2.0.0-alpha.16", | |||
There was a problem hiding this comment.
depending on a specific version here because alpha releases may include breaking changes
| @@ -19,8 +19,5 @@ | |||
| "include": [ | |||
| "src/**/*.ts", | |||
| "custom_typings/main.d.ts" | |||
| ], | |||
| "exclude": [ | |||
| "node_modules" | |||
| ] | |||
There was a problem hiding this comment.
This is implicit, as it's not included in the include section
There was a problem hiding this comment.
While I would assume the same, without these lines the atom-typescript plugin completely locks up my Atom. I am unable to perform edits in the .ts files in this project.
There was a problem hiding this comment.
Reverted!
I suspect that atom-typescript will eventually fix this bug so we should recheck every once in a while. It's possible that they haven't added support for include, as it was added fairly recently in 2.0, and if it looks like you haven't told typescript what to include (via either include or files then it will just look for **/*.[ts|js], which yeah, is super crazy slow)
