This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Handle multiple workspaces in a project #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimvdLippe
commented
Nov 28, 2016
| if (this.editorService) { | ||
| this.editorService.dispose(); | ||
| // TODO(timvdlippe): Expose as user setting? | ||
| if (this.workspaces.size == 10) { |
There was a problem hiding this comment.
Should probably be >= 10 to guard against adding a workspace if not one was removed, but also one was added.
| lintOnFly: true, | ||
| lint: (editor) => { | ||
| const project = this.getProjectPathFromEditor(editor); | ||
| return this.workspaces.get(project)[1].linter.lint(editor); |
There was a problem hiding this comment.
What if project does not exist in this.workspaces?
| selector: '.text.html, .source.js', | ||
| getSuggestions: (options) => { | ||
| const project = this.getProjectPathFromEditor(options.editor); | ||
| return this.workspaces.get(project)[1].autocompleter.getSuggestions(options); |
There was a problem hiding this comment.
What if project does not exist in this.workspaces?
| deactivate() { | ||
| this.subscriptions.dispose(); | ||
| this.subscriptions = null; | ||
| this.workspaces = new Map(); |
There was a problem hiding this comment.
Do we also need to clean up the linter, autocompleter and tooltipmanager or is this already sufficient? We could also add them to this.subscriptions when we create them inside updateWorkspaceMap
|
Yes, this should be handled at the atom-languageclient level if it isn't already. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin should now be able to handle multiple projects. It does so by keeping track of at most 10 workspaces at the same time. Every time a file is opened, the workspace is inserted or the file counter is incremented. When a file is closed, the workspace file counter is decremented.
If there are more than 10 workspaces, it will try to remove the first workspace that has no more files open and remove that workspace from the map.
When the linter or autocomplete functions are invoked, the corresponding linter/autcompleter of the editor is looked up and returned.
Fixes #6