This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Prepare for editor.save becoming async
#64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #63 This fix should be both backcompatible and forwardcompatible, as returning something that's not a promise from a promise callback will resolve immediately, whereas returning a promise will wait for the promise, so it should do the right thing whether save is sync or async.
|
Seems like a nice fix. Lets see if the tests still pass 😄 |
TimvdLippe
approved these changes
Jun 16, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63
This fix should be both backcompatible and forwardcompatible, as returning something that's not a promise from a promise callback will resolve immediately, whereas returning a promise will wait for the promise, so it should do the right thing whether save is sync or async.