Update site to use Polymer 2.0 #2318

keanulee · 2017-09-05T23:02:49Z

Staged at https://polymer-2-dot-polymer-project.appspot.com/ - please leave feedback as comments here on this PR.

TODOs:

keanulee · 2017-09-14T04:35:29Z

The staging website (https://polymer-2-dot-polymer-project.appspot.com) is now ready for testing on all browsers, including IE 11! I'm waiting until patched dependencies are merged and tagged before merging this PR though.

notwaldorf · 2017-09-14T22:32:22Z

I have been browsing and refreshing this for the last 5 minute on IE11, and it's pretty aces!

notwaldorf · 2017-09-14T22:58:10Z

app/2.0/samples/homepage/contact-card/index.html

@@ -1,7 +1,7 @@
 <!DOCTYPE html>
 <html lang="en">
  <head>
-    <script src="../../../../bower_components/webcomponentsjs/webcomponents-lite.min.js"></script>
+    <script src="bower_components/webcomponentsjs/webcomponents-loader.js"></script>


notwaldorf · 2017-09-14T22:58:47Z

app/2.0/samples/homepage/google-map/bower_components

@@ -0,0 +1 @@
+../../../../bower_components


oh is this a link? smart!

notwaldorf · 2017-09-14T22:59:34Z

app/elements/demo-tabs.html

      </iron-pages>
    </div>

    <div class="results">
-      <content select="iframe"></content>
+      <slot select="iframe"></slot>


this should be name="iframe", no?

It should be <slot name="iframe"> with the corresponding iframes updated with slot="iframe", but since there's no default slot before I'm just going to make this the default (and remove select="iframe").

notwaldorf · 2017-09-14T22:59:53Z

app/elements/lazy-elements.html

 <link rel="import" href="../bower_components/app-layout/helpers/helpers.html">
 <link rel="import" href="../bower_components/iron-collapse/iron-collapse.html">
 <link rel="import" href="../bower_components/iron-selector/iron-selector.html">
 <link rel="import" href="../bower_components/paper-icon-button/paper-icon-button.html">
 <link rel="import" href="../bower_components/paper-item/paper-item.html">
 <link rel="import" href="../bower_components/paper-listbox/paper-listbox.html">
-<link rel="import" href="../bower_components/paper-toast/paper-toast.html">


isn't the toast needed by the service worker code?

(like, why isn't it lazy anymore)

On Firefox (at least), if you navigate to a non-cached page, the toast won't be upgraded and you don't see it (and get an ugly "show is not a function" error).

notwaldorf · 2017-09-14T23:01:16Z

app/elements/pw-shell.html

-        Polymer.dom(this).appendChild(document.importNode(fragment, true));
+        // Replace shell contents.
+        var shell = Polymer.dom(this);
+        while (shell.firstChild) {


Why is this better than shell.innerHTML = '';?

DOM manipulations are faster than invoking the parser, I think (even for empty strings), though the real motivation behind this change was that setting innerHTML was causing issues.

notwaldorf · 2017-09-14T23:01:59Z

bower.json

-    "iron-selector": "2",
-    "webcomponentsjs": "^0.7.24"
+    "iron-location": "fix-ie-capture",
+    "webcomponentsjs": "master"


but you're going to update this to depend on real releases before you merge this, right?

notwaldorf · 2017-09-14T23:02:50Z

templates/head-meta.html

-  window.Polymer = window.Polymer || {dom: 'shadow', lazyRegister: true};
-</script>
-<!-- Node: the webcomponents polyfill is lazily loaded in app.js -->
+<script>!function(e){var r=e.babelHelpers={};r.typeof="function"==typeof Symbol&&"symbol"==typeof Symbol.iterator?function(e){return typeof e}:function(e){return e&&"function"==typeof Symbol&&e.constructor===Symbol&&e!==Symbol.prototype?"symbol":typeof e},r.classCallCheck=function(e,r){if(!(e instanceof r))throw new TypeError("Cannot call a class as a function")},r.createClass=function(){function e(e,r){for(var t=0;t<r.length;t++){var n=r[t];n.enumerable=n.enumerable||!1,n.configurable=!0,"value"in n&&(n.writable=!0),Object.defineProperty(e,n.key,n)}}return function(r,t,n){return t&&e(r.prototype,t),n&&e(r,n),r}}(),r.defineEnumerableProperties=function(e,r){for(var t in r){var n=r[t];n.configurable=n.enumerable=!0,"value"in n&&(n.writable=!0),Object.defineProperty(e,t,n)}return e},r.defaults=function(e,r){for(var t=Object.getOwnPropertyNames(r),n=0;n<t.length;n++){var o=t[n],i=Object.getOwnPropertyDescriptor(r,o);i&&i.configurable&&void 0===e[o]&&Object.defineProperty(e,o,i)}return e},r.defineProperty=function(e,r,t){return r in e?Object.defineProperty(e,r,{value:t,enumerable:!0,configurable:!0,writable:!0}):e[r]=t,e},r.extends=Object.assign||function(e){for(var r=1;r<arguments.length;r++){var t=arguments[r];for(var n in t)Object.prototype.hasOwnProperty.call(t,n)&&(e[n]=t[n])}return e},r.get=function e(r,t,n){null===r&&(r=Function.prototype);var o=Object.getOwnPropertyDescriptor(r,t);if(void 0===o){var i=Object.getPrototypeOf(r);return null===i?void 0:e(i,t,n)}if("value"in o)return o.value;var a=o.get;if(void 0!==a)return a.call(n)},r.inherits=function(e,r){if("function"!=typeof r&&null!==r)throw new TypeError("Super expression must either be null or a function, not "+typeof r);e.prototype=Object.create(r&&r.prototype,{constructor:{value:e,enumerable:!1,writable:!0,configurable:!0}}),r&&(Object.setPrototypeOf?Object.setPrototypeOf(e,r):e.__proto__=r)},r.instanceof=function(e,r){return null!=r&&"undefined"!=typeof Symbol&&r[Symbol.hasInstance]?r[Symbol.hasInstance](e):e instanceof r},r.newArrowCheck=function(e,r){if(e!==r)throw new TypeError("Cannot instantiate an arrow function")},r.objectDestructuringEmpty=function(e){if(null==e)throw new TypeError("Cannot destructure undefined")},r.objectWithoutProperties=function(e,r){var t={};for(var n in e)r.indexOf(n)>=0||Object.prototype.hasOwnProperty.call(e,n)&&(t[n]=e[n]);return t},r.possibleConstructorReturn=function(e,r){if(!e)throw new ReferenceError("this hasn't been initialised - super() hasn't been called");return!r||"object"!=typeof r&&"function"!=typeof r?e:r},r.set=function e(r,t,n,o){var i=Object.getOwnPropertyDescriptor(r,t);if(void 0===i){var a=Object.getPrototypeOf(r);null!==a&&e(a,t,n,o)}else if("value"in i&&i.writable)i.value=n;else{var u=i.set;void 0!==u&&u.call(o,n)}return n},r.slicedToArray=function(){function e(e,r){var t=[],n=!0,o=!1,i=void 0;try{for(var a,u=e[Symbol.iterator]();!(n=(a=u.next()).done)&&(t.push(a.value),!r||t.length!==r);n=!0);}catch(e){o=!0,i=e}finally{try{!n&&u.return&&u.return()}finally{if(o)throw i}}return t}return function(r,t){if(Array.isArray(r))return r;if(Symbol.iterator in Object(r))return e(r,t);throw new TypeError("Invalid attempt to destructure non-iterable instance")}}(),r.taggedTemplateLiteral=function(e,r){return Object.freeze(Object.defineProperties(e,{raw:{value:Object.freeze(r)}}))},r.temporalRef=function(e,r,t){if(e===t)throw new ReferenceError(r+" is not defined - temporal dead zone");return e},r.temporalUndefined={},r.toArray=function(e){return Array.isArray(e)?e:Array.from(e)},r.toConsumableArray=function(e){if(Array.isArray(e)){for(var r=0,t=Array(e.length);r<e.length;r++)t[r]=e[r];return t}return Array.from(e)}}("undefined"==typeof global?self:global);</script>


Yum. What is this?

FluorescentHallucinogen · 2017-09-15T09:47:29Z

@keanulee Could you please also update the old and/or deprecated versions of dependencies such as app-layout#^0.0.14 and firebase-element#^1.0.12 to actual versions?

FluorescentHallucinogen · 2017-09-15T10:00:24Z

@keanulee Oh, dependenies are already updated. Please ignore my previous message. One question: why you don't use version ranges in bower.json for some dependenies (e.g. paper-item#^2.0.0 instead of paper-item#2)?

keanulee · 2017-09-15T18:30:51Z

@FluorescentHallucinogen I like #2 because it's succinct. It equivalent to #^2.0.0, just personal preference 😉 (Note that #2.2.5 is NOT equivalent to #^2.2.5 - 2 means versions that "start with 2", where the latter is an exact match)

arthurevans · 2017-10-03T00:30:24Z

Is the IE iron-location issue the last issue blocking this?

keanulee · 2017-10-03T20:06:53Z

The iron-location fix is now published and I updated the staging site with the latest bower deps (https://polymer-2-dot-polymer-project.appspot.com/). I tested the latest update and everything seems to be good. @arthurevans wanna give it one last check and merge? (I believe I already addressed all @notwaldorf 's feedback.)

arthurevans · 2017-10-03T23:05:34Z

bower.json

-    "promise-polyfill": "polymerlabs/promise-polyfill#^1.0.0",
-    "google-youtube": "GoogleWebComponents/google-youtube#^1.2.1",
-    "google-map": "GoogleWebComponents/google-map#^1.1.10",
+    "promise-polyfill": "polymerlabs/promise-polyfill#2",


I think we can drop the separate promise-polyfill now... There's a promise polyfill in the v1 WC polyfills, so WC-loader should take care of this, I think. (Only needed this to run the hybrid iron-ajax against 1.x, IIRC).

arthurevans · 2017-10-03T23:06:30Z

Will pull and do a test build tomorrow to make sure I don't have any issues building locally.

keanulee added 2 commits August 31, 2017 14:29

Migrate to Polymer 2 WIP

ac5c700

Compile to ES5

05a307b

googlebot added the cla: yes label Sep 5, 2017

keanulee added 6 commits September 6, 2017 14:02

Fix page navigation (innerHTML issue with shady dom)

0c733fd

Build demos

56026a0

Inline wc polyfill on summit pages

2086811

Make SW compatible with v1 wc polyfills

feb8a94

Remove abandoned file

e6bb296

polymer build homepage demos

9047bf3

keanulee force-pushed the 2.0 branch from 5ab7cb0 to 9047bf3 Compare September 8, 2017 22:15

keanulee requested review from notwaldorf, arthurevans and a user September 14, 2017 04:33

notwaldorf suggested changes Sep 14, 2017

View reviewed changes

Fix demo-tabs and footer image; add comment WIP

ceff742

keanulee force-pushed the 2.0 branch from 997bc03 to ceff742 Compare September 15, 2017 00:46

keanulee added 2 commits September 29, 2017 11:44

Update bower.json

7a347f1

Merge branch 'master' into 2.0

bc00e24

ghost approved these changes Oct 2, 2017

View reviewed changes

iron-location now fixed

2eade83

keanulee changed the title ~~[DO NOT MERGE] Update site to use Polymer 2.0~~ Update site to use Polymer 2.0 Oct 3, 2017

arthurevans reviewed Oct 3, 2017

View reviewed changes

arthurevans merged commit 1cd2cb5 into master Oct 4, 2017

keanulee deleted the 2.0 branch October 4, 2017 21:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update site to use Polymer 2.0 #2318

Update site to use Polymer 2.0 #2318

keanulee commented Sep 5, 2017 •

edited

Loading

keanulee commented Sep 14, 2017

notwaldorf commented Sep 14, 2017

notwaldorf Sep 14, 2017

notwaldorf Sep 14, 2017

notwaldorf Sep 14, 2017

keanulee Sep 15, 2017

notwaldorf Sep 14, 2017

notwaldorf Sep 14, 2017

keanulee Sep 14, 2017

notwaldorf Sep 14, 2017

keanulee Sep 14, 2017

notwaldorf Sep 14, 2017

notwaldorf Sep 14, 2017

FluorescentHallucinogen commented Sep 15, 2017

FluorescentHallucinogen commented Sep 15, 2017

keanulee commented Sep 15, 2017 •

edited

Loading

arthurevans commented Oct 3, 2017

keanulee commented Oct 3, 2017

arthurevans Oct 3, 2017

arthurevans commented Oct 3, 2017

		@@ -0,0 +1 @@
		../../../../bower_components

Update site to use Polymer 2.0 #2318

Update site to use Polymer 2.0 #2318

Conversation

keanulee commented Sep 5, 2017 • edited Loading

keanulee commented Sep 14, 2017

notwaldorf commented Sep 14, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FluorescentHallucinogen commented Sep 15, 2017

FluorescentHallucinogen commented Sep 15, 2017

keanulee commented Sep 15, 2017 • edited Loading

arthurevans commented Oct 3, 2017

keanulee commented Oct 3, 2017

Choose a reason for hiding this comment

arthurevans commented Oct 3, 2017

keanulee commented Sep 5, 2017 •

edited

Loading

keanulee commented Sep 15, 2017 •

edited

Loading