Skip to content
This repository has been archived by the owner on Sep 24, 2021. It is now read-only.

Return the analysis from the lint pass too. #132

Merged
merged 2 commits into from
Nov 17, 2017
Merged

Return the analysis from the lint pass too. #132

merged 2 commits into from
Nov 17, 2017

Conversation

rictic
Copy link
Contributor

@rictic rictic commented Nov 16, 2017 •
edited
Loading

  • CHANGELOG.md has been updated

This change is Reviewable

@rictic
Copy link
Contributor Author

rictic commented Nov 16, 2017

This is mostly useful for makeParseLoader, when called from the cli or the ide

valdrinkoshi
valdrinkoshi reviewed Nov 17, 2017
View reviewed changes
Copy link
Member

@valdrinkoshi valdrinkoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not clear why is this needed for, my understanding is that we now add an analysis property to an array. Is this needed internally only (for the tests) or elsewhere too?

@rictic
Copy link
Contributor Author

rictic commented Nov 17, 2017

It's also useful in the CLI and IDE which call the same makeParseLoader function

valdrinkoshi
valdrinkoshi approved these changes Nov 17, 2017
View reviewed changes
Copy link
Member

@valdrinkoshi valdrinkoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rictic rictic merged commit c0fa8ae into master Nov 17, 2017
@rictic rictic deleted the emit-analysis branch November 17, 2017 00:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@valdrinkoshi valdrinkoshi valdrinkoshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rictic @valdrinkoshi