-
Notifications
You must be signed in to change notification settings - Fork 660
[3.0-preview] Update polymer.json for webcomponentsjs changes. #1109
Conversation
- Remove webcomponentsjs from `extraDependencies` - this is built in to the CLI. - Remove `moduleResolution: "node"` - this is now the default.
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
(Expecting this to fail until those two PRs are in and the dependency on polymer-cli here is updated.) |
|
Actually, no, this needs to be updated to make sure that the builds include the new location of the webcomponentsjs bundles! |
This reverts commit ba7be73.
…es for the loader.
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works. We're a little lazy and just do this (which copies more than necessary): https://github.com/Polymer/pwa-starter-kit/blob/d52fd60/polymer.json#L9
I think with these we also fix it: webcomponents/webcomponentsjs#929 |
@abdonrd is that because |
@bicknellr no, the idea is reduce the You can see the actual output here: With webcomponents/webcomponentsjs#929 we reduce the output to only:
So the |
Oh, I read "I think with these we also fix it:" and though you were referring to this bug, rather than Keanu's comment about copying more than necessary. |
@bicknellr ops! Sorry for the confusion! 😅 |
The polyfill bundles have moved into
/bundles
.