Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

[3.0-preview] Update polymer.json for webcomponentsjs changes. #1109

Merged
merged 3 commits into from
May 8, 2018

Conversation

bicknellr
Copy link
Member

@bicknellr bicknellr commented May 8, 2018

The polyfill bundles have moved into /bundles.

- Remove webcomponentsjs from `extraDependencies` - this is built in to the CLI.
- Remove `moduleResolution: "node"` - this is now the default.
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@bicknellr bicknellr changed the base branch from master to 3.0-preview May 8, 2018 01:18
@bicknellr
Copy link
Member Author

(Expecting this to fail until those two PRs are in and the dependency on polymer-cli here is updated.)

@bicknellr
Copy link
Member Author

bicknellr commented May 8, 2018

This is not a blocker: these settings work as they are currently, they'll just become redundant in the future.

@bicknellr
Copy link
Member Author

Actually, no, this needs to be updated to make sure that the builds include the new location of the webcomponentsjs bundles!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels May 8, 2018
@bicknellr bicknellr changed the title [3.0-preview] Update polymer.json for tools changes. [3.0-preview] Update polymer.json for webcomponentsjs changes. May 8, 2018
Copy link
Contributor

@keanulee keanulee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works. We're a little lazy and just do this (which copies more than necessary): https://github.com/Polymer/pwa-starter-kit/blob/d52fd60/polymer.json#L9

@abdonrd
Copy link
Contributor

abdonrd commented May 8, 2018

I think with these we also fix it: webcomponents/webcomponentsjs#929

@bicknellr bicknellr merged commit 14f8a59 into 3.0-preview May 8, 2018
@bicknellr bicknellr deleted the update-polymer-json branch May 8, 2018 21:57
@bicknellr
Copy link
Member Author

@abdonrd is that because polymer build includes things listed in files in your build output?

@abdonrd
Copy link
Contributor

abdonrd commented May 8, 2018

@bicknellr no, the idea is reduce the npm install @webcomponents/webcomponentsjs output.

You can see the actual output here:
https://unpkg.com/@webcomponents/webcomponentsjs@2.0.0-beta.2/

With webcomponents/webcomponentsjs#929 we reduce the output to only:

"bundles/**/*",
"entrypoints/**/*",
"custom-elements-es5-adapter.js",
"webcomponents-bundle.js",
"webcomponents-bundle.js.map",
"webcomponents-loader.js"

So the gulpfile.js will never exist in the project.

@bicknellr
Copy link
Member Author

Oh, I read "I think with these we also fix it:" and though you were referring to this bug, rather than Keanu's comment about copying more than necessary.

@abdonrd
Copy link
Contributor

abdonrd commented May 11, 2018

@bicknellr ops! Sorry for the confusion! 😅

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants