Allow non-JSON literals when property type is "Object". #4956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pkaske You can add a test in this suite: polymer/test/unit/attributes.html Line 90 in 4b0def6 |
|
@TimvdLippe I added some test. Are they sufficient? I'm jet not very experienced with testing web components, leave alone polymers internals. I'm more then open and thankful for any suggestions, tips, critique and hint to used anti patterns :) |
TimvdLippe
approved these changes
Nov 30, 2017
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems there are in general no tests if properties are correctly deserialized or I didn't see or get it???
If someone can give me a hint I would try to implement them.
Reference Issue
Fixes #4464