Fixes scroll lock detection in ShadowDOM #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdata
force-pushed
the
fix-scroll-lock-detection
branch
from
d5b559e
to
24bc05e
Compare
|
I just sent a similar PR (see #50). This change alone does not fix it for me. The |
| @@ -199,13 +199,13 @@ | |||
| document.body.style.overflowY = 'hidden'; | |||
|
|
|||
| // Modern `wheel` event for mouse wheel scrolling: | |||
| window.addEventListener('wheel', this._scrollInteractionHandler, true); | |||
| document.addEventListener('wheel', this._scrollInteractionHandler, true); | |||
There was a problem hiding this comment.
Don't we need to update also the removeEventListener code a few lines below?
cdata
force-pushed
the
fix-scroll-lock-detection
branch
2 times, most recently
from
043e44e
to
91419f4
Compare
|
Thanks. That is fine by me. |
| childTwo = parent.querySelector('#ChildTwo'); | ||
| grandChildOne = parent.querySelector('#GrandchildOne'); | ||
| grandChildTwo = parent.querySelector('#GrandchildTwo'); | ||
| childOne = Polymer.dom(parent.root).querySelector('#ChildOne'); |
There was a problem hiding this comment.
i think this is just parent.$$.ChildOne, which is less verbose, maybe? (here and below)
|
@cdata this is lgtm once you do those changes :) |
|
@cdata: The PR is LGTMed already. Can you provide a status update? |
added 3 commits
February 5, 2016 16:18
Scroll locking was broken in ShadowDOM because `event.path` does not contain sufficient information when `currentTarget` is `window`. Listeners are now being added to `document` instead.
cdata
force-pushed
the
fix-scroll-lock-detection
branch
from
91419f4
to
e6cf173
Compare
cdata
added a commit
that referenced
this pull request
Feb 6, 2016
Fixes scroll lock detection in ShadowDOM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scroll locking was broken in ShadowDOM because
event.pathdoes notcontain sufficient information when
currentTargetiswindow.Listeners are now being added to
documentinstead.