Inverts arrow key focus movement when in an RTL context. #41
Conversation
|
Hmm, |
|
I think this needs Polymer/polymer#2717 also. |
| assert.equal(document.activeElement, menubar.items[2], 'document.activeElement is next item'); | ||
| done(); | ||
| // wait for async in _onFocus | ||
| }, 200); |
There was a problem hiding this comment.
why 200 and not 100, or 1? it is waiting for an animation to finish, or just a microtask?
There was a problem hiding this comment.
I think I copied this from the other examples with the assumption that both actions would need to wait for the same thing because they both affect focus, so I wouldn't be surprised if the timing is too loose. I'll look more into this.
|
@bicknellr ping! what's the status of this? (also: tests are hella grumpy) |
|
update: Polymer/polymer#2717 is in as of not too long ago, but it isn't in a release yet so this is still blocked. |
…selection remains the same on focus change from arrow keys.
bicknellr
force-pushed
the
bicknellr/paper-tabs_issue-85
branch
from
d27601b
to
befda3c
Compare
| '`menubar.selected` should not change.'); | ||
| done(); | ||
| // wait for async in _onFocus | ||
| }, 200); |
There was a problem hiding this comment.
(This comment is still applicable.)
|
I took out all the |
| assert.equal(menubar.selected, 1, | ||
| '`menubar.selected` should not change.'); | ||
|
|
||
| done(); |
There was a problem hiding this comment.
no done needed anymore :)
|
LGTM % nit. Ship it! |
…e-85 Inverts arrow key focus movement when in an RTL context.
Needed by PolymerElements/paper-tabs#84.