-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add allow-outside-scroll property #70
Conversation
This PR needs a rebase. |
This now depends on PolymerElements/paper-menu-button#67 (because of all the rebases). |
@mattppp "paper-menu-button": "PolymerElements/paper-menu-button#^1.2.0", |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
@mattppp looks like there are issues with the CLA signature. Could you squash the commits all in one and send it with your github user? |
Not quite sure what's up with the CLA. It looks like it's signed from my end. |
CLAs look good, thanks! |
Had an old email on the commit. Thanks for the help :) |
Awesome! Thanks for the contribution @mattppp! |
@mattppp, my bad, I just noticed this should be added also to |
Adding an allow-scroll-lock property implemented in
iron-dropdown
PR #25, to make it accessible inpaper-dropdown-menu
. This depends on 'paper-menu-button' PR #35 being merged.