Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allow-outside-scroll property #70

Merged
merged 1 commit into from
Jul 8, 2016

Conversation

mattprivman
Copy link
Contributor

Adding an allow-scroll-lock property implemented in iron-dropdown PR #25, to make it accessible in paper-dropdown-menu. This depends on 'paper-menu-button' PR #35 being merged.

@cdata
Copy link
Contributor

cdata commented Feb 18, 2016

This PR needs a rebase.

@valdrinkoshi
Copy link
Member

valdrinkoshi commented Jul 1, 2016

This now depends on PolymerElements/paper-menu-button#67 (because of all the rebases).
Once that is merged, we need to update the bower dependency of paper-dropdown-menu to depend on the correct minimum version of paper-menu-button

@valdrinkoshi
Copy link
Member

@mattppp paper-menu-button v1.2.0 has been released, and it exposes allow-outside-scroll property. Could you update bower.json to require this version?

"paper-menu-button": "PolymerElements/paper-menu-button#^1.2.0",

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@googlebot googlebot added cla: no and removed cla: yes labels Jul 7, 2016
@valdrinkoshi
Copy link
Member

@mattppp looks like there are issues with the CLA signature. Could you squash the commits all in one and send it with your github user?

@mattprivman
Copy link
Contributor Author

Not quite sure what's up with the CLA. It looks like it's signed from my end.

@valdrinkoshi
Copy link
Member

I think the problem is due to the fact that you did the commit without signing as @mattppp
screen shot 2016-07-08 at 3 05 28 am

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Jul 8, 2016
@mattprivman
Copy link
Contributor Author

Had an old email on the commit. Thanks for the help :)

@valdrinkoshi
Copy link
Member

Awesome! Thanks for the contribution @mattppp!

@valdrinkoshi valdrinkoshi merged commit fcb0923 into PolymerElements:master Jul 8, 2016
@valdrinkoshi
Copy link
Member

valdrinkoshi commented Jul 8, 2016

@mattppp, my bad, I just noticed this should be added also to paper-dropdown-menu-light :x
Would you mind doing it? Otherwise I can take care of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants