Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing semicolon can occasionally break uglify #475

Closed
web-padawan opened this issue Jan 23, 2017 · 0 comments
Closed

Missing semicolon can occasionally break uglify #475

web-padawan opened this issue Jan 23, 2017 · 0 comments

Comments

@web-padawan
Copy link
Contributor

Description

This line should have semicolon to prevent minify issues (can be reproduced by using uglify included byvulcanize)

Will send a PR to fix that.

BTW, what about adding eslint to polymer elements repos?
notwaldorf added a commit that referenced this issue Jan 23, 2017
@notwaldorf
Merge pull request #476 from web-padawan/fix-semicolon
56c2676 
Add missing semicolon. Fixes #475
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@web-padawan