Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support removing entities from list #416

Merged
merged 1 commit into from
Oct 4, 2017
Merged

Support removing entities from list #416

merged 1 commit into from
Oct 4, 2017

Conversation

mariakleiner
Copy link
Contributor

No description provided.

@mariakleiner mariakleiner changed the title support removing entities from list WIP support removing entities from list Sep 26, 2017

defineParticle(({DomParticle, resolver}) => {

let host = `[manage-products]`;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is basically same as ShowProducts, but with a "remove" button on each product.
I didn't want to change ShowProducts but I wanted to be able to test the remove functionality, so I added it, but I'm not sure it's worth being submitted here. WDYT is best?

@mariakleiner mariakleiner changed the title WIP support removing entities from list Support removing entities from list Oct 4, 2017
@mariakleiner
Copy link
Contributor Author

Updated it to use the real entity IDs, please, take a look when you have a minute.

Thanks!

@mariakleiner mariakleiner merged commit 021224b into PolymerLabs:master Oct 4, 2017
@mariakleiner mariakleiner deleted the viewlet-remove branch October 4, 2017 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants