Skip to content
This repository has been archived by the owner on Aug 17, 2019. It is now read-only.

Removed encodeURIComponent wrapper on options.callback in src/auth/request.js #49

Merged
merged 1 commit into from Jan 16, 2015

Conversation

learntoswim
Copy link

Tested this in reference to issue #48.

Seems to be working ok.

@Pomax Pomax changed the title Removed encodeURIComponent wrapper on options.callback in src/auth/reque... Removed encodeURIComponent wrapper on options.callback in src/auth/request.js Jan 15, 2015
@Pomax
Copy link
Owner

Pomax commented Jan 15, 2015

Are you able to verify this also works if no callback URL is used?

@learntoswim
Copy link
Author

Not supplying a callback property in options:

var options = {
    api_key: api_key
    secret: secret
};

Flickr.authenticate(options, function (err, flickr) {
    // Stuff
});

Works as expected:

URL: https://www.flickr.com/services/oauth/authorize.gne
&
prompt: oauth_verifier:  

@Pomax
Copy link
Owner

Pomax commented Jan 16, 2015

cool. let's merge this in =)

And thank you for helping improve the package!

Pomax added a commit that referenced this pull request Jan 16, 2015
Removed encodeURIComponent wrapper on options.callback in src/auth/request.js
@Pomax Pomax merged commit e5c8130 into Pomax:master Jan 16, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants