Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No reaction on disableOnClickOutside property change #317

Open
todesstoss opened this issue Apr 13, 2019 · 0 comments
Open

No reaction on disableOnClickOutside property change #317

todesstoss opened this issue Apr 13, 2019 · 0 comments

Comments

@todesstoss
Copy link

Hello, It seems that after last update i should explicitly call enableOnClickOutside method to enable functionality if initially disableOnClickOutside property was false.
It's not the way it used to work before and this change breaks my code.

I think methods enableOnClickOutside/disableOnClickOutside should be called in componentDidUpdate hook on disableOnClickOutside prop change.

I can prepare PR if you don't mind.

Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant