A Recorder role #31
Closed
A Recorder role #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraih
reviewed
Apr 1, 2021
kiwiroy
force-pushed
the
recorder-role
branch
2 times, most recently
from
76b8d62
to
ee3aea4
Compare
|
Let me know when you want me to re-review this |
|
@kpeters-cbsi Just cleared out the last of the signatures, so if you don't mind having an inspection. |
|
ok, i'll have a look-see this evening
…On Wed, Aug 4, 2021 at 5:20 AM Roy Storey ***@***.***> wrote:
@kpeters-cbsi <https://github.com/kpeters-cbsi> Just cleared out the last
of the signatures, so if you don't mind having an inspection.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#31 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABGUGC7VYRMNB5JJEOCJ53T3EH7FANCNFSM4Z2672UQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
--
Kit Peters, W0KEH
GPG public key fingerpint: D4FF AA62 AFEA 83D6 CC98 ACE5 6FAE 7E74 7F56 ED1D
Hello to any and all NSA, DEA, or other government or non-government agents
reading this email. Tell me about your life; I'll tell you about mine.
|
kpeters-cbsi
approved these changes
Aug 10, 2021
| my $t = Test::Mojo->new; | ||
| my (@results, @transactions); | ||
| my @promises = ( | ||
| $t->ua->get_p(q{https://www.vam.ac.uk/api/json/museumobject/O1}), |
There was a problem hiding this comment.
This is fine, but in future I think we should do away with the external websites altogether and instead fork a dedicated HTTP server to test against. Provided, of course, that doesn't break Jenkins...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #30, this PR adds a recorder role, which is easier to compose in.
There's only 2 tests, one standalone UA and one with a lite app, but it is in a reasonable state to kick around.