Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social share contributions #1896

Merged
merged 2 commits into from
Sep 13, 2018
Merged

Social share contributions #1896

merged 2 commits into from
Sep 13, 2018

Conversation

amiedes
Copy link
Contributor

@amiedes amiedes commented Sep 13, 2018

Closes #1893

✌️ What does this PR do?

Adds support for accessing contributions via permalink and sharing them via social networks.

🔍 How should this be manually tested?

You can now access a contribution via permalink: http://newal******as.gobify.net/participacion/p/planmaestro-al******as-programa-de-renovacion-urbana/aportaciones/que-acciones-harias-para-mejorar-tu-distrito#aumentar-el-ancho-de-las-aceras and share it.

Also, now if you open/close several cards, the blinking is gone.

@@ -1148,7 +1148,7 @@ $lighter_black: rgba($color_headers, 0.7);
color: $green;
}

.button {
.button, a.social_share {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selectors must be placed on new lines single-line-per-selector

@ferblape
Copy link
Member

👍 customer can be notified

@ferblape ferblape merged commit c809845 into master Sep 13, 2018
@ferblape ferblape deleted the social-share-contribution branch September 13, 2018 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Social share for contributions
3 participants