-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to BFO 2.0? #36
Comments
@rlwalls2008, If you'd like, I can work on it this weekend. We have developed an online tool for the BFO conversion. |
Jie, That would be really super! Yes, please! Are you zhengj2007? Ramona Ramona L. Walls, Ph.D. On Thu, Jun 2, 2016 at 7:40 AM, jie zheng notifications@github.com wrote:
|
@rlwalls2008 Yes, my account is zhengj2007. I will work on the conversion this weekend and let you know when I am done. |
Thank you! I just sent you an invitation to join the github organization. Ramona Ramona L. Walls, Ph.D. On Thu, Jun 2, 2016 at 12:56 PM, jie zheng notifications@github.com wrote:
|
I have accepted the invitation. |
I checked the development version PCO. It has been updated to BFO 2. I think that I have updated the files when I added 'household' in PCO. However, no release of PCO is made after changes. I found some minor issues and made following changes: (This BFO classes only file has slight difference from the latest BFO 2.0 release. However, I will make some minor changes on BFO 2.0. So, would like to defer import this version BFO owl file.) 2). remove file: ro_imports.owl The advantage of using RO core is that most of relations in the core file with defined domain and range which are very useful.
After made these changes, I checked the PCO. It looks fine. All RO relations used in pco.owl are available in the RO core. Running Hermit reasoner, no inconsistent terms are found. The changes I made can be viewed in the bfo2 branch: If no objection on the changes I made, I will merge bfo2 branch to the master and make a new release of PCO based on it. If anyone would like to review the files before I make the merge would be great. In addition, I found the ontoFox input file for importing GO terms is same as PATO one. Need to find the ontoFox input file for GO terms. |
Thanks Jie!
|
@pbuttigieg Welcome! @rlwalls2008 |
@zhengj2007 Thanks for all the work! Sorry I didn't see your message sooner. I will review before Friday. Before the release, I need to add a bunch of new terms that have been requested. Should I just add those in the bfo2 branch? I can get them in by Friday, so you can work on the release over the weekend. I'll have a look at taxonomic rank too. |
@rlwalls2008 I think it would be nice to include the new terms in the release. If you review the BFO2 version is good, I'd prefer to merge it to the master branch before you add the new terms. Could you please let me know when you finish the review? Then I will merge the files to the master branch. I will let you know when I am done with it and make the release after you add the new terms. How do you think? |
Perfect, @zhengj2007. I will try to review today and let you know when I am done. |
@rlwalls2008 Thanks! |
@zhengj2007 Sorry tit took so long, but I just reviewed the branch, and it looks great. Please go ahead and merge. I will add new terms tomorrow and a few other things, so we can do a release. If you don't have time to do the merge before tomorrow, I can work on another branch. |
On further thought, @zhengj2007 , why don't I just merge the branch? As the repo owner, I should be able to do that. I'll let you know when it ready for the release. |
Hi!
We're trying to import PCO, but it still uses old BFO classes.
Would this be updated soon? Would be good to avoid building code to merge this with other imports.
The text was updated successfully, but these errors were encountered: